After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646876 - Free MenuPopulateData struct in all the cases.
Free MenuPopulateData struct in all the cases.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkRecent
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
Emmanuele Bassi (:ebassi)
Depends on:
Blocks:
 
 
Reported: 2011-04-06 02:56 UTC by Paolo Borelli
Modified: 2011-04-15 09:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Free MenuPopulateData struct in all the cases. (2.37 KB, patch)
2011-04-06 02:56 UTC, Paolo Borelli 		needs-work Details | Review
patch (2.33 KB, patch)
2011-04-06 04:50 UTC, Paolo Borelli 		none Details | Review

Description Paolo Borelli 2011-04-06 02:56:48 UTC 
For clarity factor out create/free functions.
Comment 1 Paolo Borelli 2011-04-06 02:56:50 UTC 
Created attachment 185249 [details] [review]
Free MenuPopulateData struct in all the cases.
Comment 2 Matthias Clasen 2011-04-06 04:19:45 UTC 
Review of attachment 185249 [details] [review]:

Looks fine to me, except for the recursion.

::: gtk/gtkrecentchoosermenu.c
@@ +975,3 @@
+  MenuPopulateData *pdata;
+
+  pdata = create_menu_populate_data (menu);

This looks dangerously recursive...
Comment 3 Paolo Borelli 2011-04-06 04:50:35 UTC 
Created attachment 185257 [details] [review]
patch

oops, sorry I forgot to commit --amend before attaching the patch
Comment 4 Paolo Borelli 2011-04-15 09:16:05 UTC 
(In reply to comment #2)
> Looks fine to me, except for the recursion.

I pushed the fixed patch to master and 3-0