After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646825 - StScrollbar: clean up properly when unmapped during scroll
StScrollbar: clean up properly when unmapped during scroll
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-04-05 14:57 UTC by Owen Taylor
Modified: 2011-04-11 21:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
StScrollbar: clean up properly when unmapped during scroll (3.04 KB, patch)
2011-04-05 14:57 UTC, Owen Taylor 		reviewed Details | Review

Description Owen Taylor 2011-04-05 14:57:31 UTC 
This should fix a bad bug when if an access point is added and the
network menu pops down (see bug 646580), we end up with trashed event
handling.
Comment 1 Owen Taylor 2011-04-05 14:57:34 UTC 
Created attachment 185207 [details] [review]
StScrollbar: clean up properly when unmapped during scroll

If we're unmapped (or destroyed) during a scroll, we want to clean
up the changes we've made to Clutter's event handling, remove our
signal handler, and emit ::scroll-stop.
Comment 2 Dan Winship 2011-04-05 15:04:36 UTC 
Comment on attachment 185207 [details] [review]
StScrollbar: clean up properly when unmapped during scroll

code seems to work, patch looks right

>+  stage = clutter_actor_get_stage(bar->priv->trough);

it was there in the original, but there's a missing space both here and the other place you cut+pasted this line.
Comment 3 Vincent Untz 2011-04-05 15:08:44 UTC 
This fixes the bug I was seeing.
Comment 4 Dan Winship 2011-04-11 21:44:15 UTC 
this was committed