GNOME Bugzilla – Bug 646744
libgsttag: Minor issues building gst-plugins-base with MS compiler
Last modified: 2011-04-05 08:41:41 UTC
Minor fixes to the tag library making it build with the MS compiler. See attached patches.
Created attachment 185146 [details] [review] Explicit cast to GThreadFunc to avoid warning
Created attachment 185148 [details] [review] Constness removed to avoid cast warning. The const isn't needed if you ask me... some might disagree!?
Created attachment 185149 [details] [review] Use gst/math-compat.h instead of just plain math.h
Does this in addition to your patches make it work as well: diff --git a/gst-libs/gst/tag/xmpwriter.c b/gst-libs/gst/tag/xmpwriter.c index b3a56b7..4f14a78 100644 --- a/gst-libs/gst/tag/xmpwriter.c +++ b/gst-libs/gst/tag/xmpwriter.c @@ -311,7 +311,8 @@ gst_tag_xmp_writer_tag_list_to_xmp_buffer (GstTagXmpWriter * config, for (iter = data->schemas; iter; iter = g_slist_next (iter)) { array[i++] = (gchar *) iter->data; } - buf = gst_tag_list_to_xmp_buffer_full (taglist, read_only, array); + buf = gst_tag_list_to_xmp_buffer_full (taglist, read_only, + (const gchar **) array); g_free (array); } } gcc complains about it otherwise (guess the const-ness of string arrays is a bit muddled in the g-world..)
I think it should work fine, so just pushed it: commit 834a5a478c127c992e15a16f49883be94a9e3980 Author: Haakon Sporsheim <haakon.sporsheim@gmail.com> Date: Mon Apr 4 17:21:45 2011 +0200 tag: use gst/math-compat.h header. https://bugzilla.gnome.org/show_bug.cgi?id=646744 commit f7036eb26027dd5d08a8f88f3165f74dab2ac73d Author: Haakon Sporsheim <haakon.sporsheim@gmail.com> Date: Mon Apr 4 17:23:53 2011 +0200 tag: Remove constness to silence MS compiler. https://bugzilla.gnome.org/show_bug.cgi?id=646744 commit 7b142178e4f26d23248928133e38e64649b9d317 Author: Haakon Sporsheim <haakon.sporsheim@gmail.com> Date: Mon Apr 4 17:23:13 2011 +0200 tag: Explicit cast to GThreadFunc to silence MS compiler. https://bugzilla.gnome.org/show_bug.cgi?id=646744 Thanks for the patches!
Sure, even better. Thanks!