After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646558 - network: deal with recycling of closed active connections
network: deal with recycling of closed active connections
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: GnomeShell301
 
 
Reported: 2011-04-02 19:34 UTC by Owen Taylor
Modified: 2011-04-11 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: deal with recycling of closed active connections (1.31 KB, patch)
2011-04-02 19:34 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2011-04-02 19:34:19 UTC 
If you restart NetworkManager, then the list of active connections
is emptied, then comes back with the same GObjects in it. If the
_primaryDevice field isn't cleared on the object, then we won't
know we need to set it back on the device, resulting in the active
device not showing up in the menu.
Comment 1 Owen Taylor 2011-04-02 19:34:21 UTC 
Created attachment 184967 [details] [review]
network: deal with recycling of closed active connections
Comment 2 Giovanni Campagna 2011-04-02 19:39:02 UTC 
Review of attachment 184967 [details] [review]:

Looks good, even if it is weird that the proxies are not tied to the name owner.
Comment 3 Dan Winship 2011-04-02 21:53:05 UTC 
Comment on attachment 184967 [details] [review]
network: deal with recycling of closed active connections

not sure if you were planning to commit this for 3.0.0; "restarting NM" makes it seem pretty edge-casey. but if so, yes, it looks right
Comment 4 Owen Taylor 2011-04-03 02:03:49 UTC 
Not too concerned about this for 3.0.0; restarting NetworkManager hopefully won't be that common. Will target 3.0.1.
Comment 5 Dan Winship 2011-04-11 14:44:49 UTC 
Attachment 184967 [details] pushed as 529b6ca - network: deal with recycling of closed active connections