GNOME Bugzilla – Bug 646498
GTK+ 3.0.7 causes gdm greeter to crash at startup
Last modified: 2011-06-13 21:53:18 UTC
Created attachment 184919 [details] [review] gdm greeter log, containing the backtrace reverting to 3.0.6 fixes the crash.
This is a gdm bug. And because g_return_if_fail() makes the greeter explode (I suppose it's catching criticals on purpose?), it will always die, even though I've tried to reinstate the size_allocate checks as they were in 3.0.6. At least it doesn't crash inside gdb anymore.
Created attachment 184925 [details] [review] simple-greeter: Don't request an invalid size GTK widgets must at all times report a size they can handle. So it is not allowed to return 0 when not realized, because then size allocations break when GTK uses this size for its widget. In this case, GTK uses the pre-realize size to determine the size it should request when creating the greeter window - chicken and egg so to say. This patch just uses the default monitor (I guess the root window's monitor is the default monitor?) for determining the login window size. One thing this patch doesn't do is add a call to gtk_widget_queue_resize() from the realize callback or from monitor-changing signals, though that's probably technically necessary.
Comment on attachment 184925 [details] [review] simple-greeter: Don't request an invalid size Created a scratch build with this fix http://koji.fedoraproject.org/koji/taskinfo?taskID=2967748 and installed GTK+ 3.0.7 again (I had reverted it previously). I can confirm this patch fixes this issue for me.
that patch fixes this issue for me.
The gtk change has been reverted in 3.0.8, so this is no longer a 3.0 blocker
Thanks, pushed