After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646420 - g_dbus_method_invocation_get_parameters() docs should say it returns a tuple
g_dbus_method_invocation_get_parameters() docs should say it returns a tuple
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-04-01 08:51 UTC by Murray Cumming
Modified: 2011-04-03 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
646420 - (1.14 KB, patch)
2011-04-02 13:46 UTC, Murray Cumming 		accepted-commit_now Details | Review

Description Murray Cumming 2011-04-01 08:51:39 UTC 
Presumably the g_dbus_method_invocation_get_parameters() documentation
  http://library.gnome.org/devel/gio/unstable/GDBusMethodInvocation.html#g-dbus-method-invocation-get-parameters
should mention that it returns a tuple GVariant.

If so, I'll make that fix.
Comment 1 David Zeuthen (not reading bugmail) 2011-04-01 13:41:47 UTC 
We could mention this. But before doing this, please check that NULL is never returned (for e.g. methods with no IN parameters).
Comment 2 Murray Cumming 2011-04-02 13:46:40 UTC 
Created attachment 184942 [details] [review]
646420 -

I checked and found that it returns an empty (0 children) tuple GVariant in that case. _g_dbus_method_invocation_new()'s code also checks that it is non-NULL.

Is it OK to push this patch?
Comment 3 David Zeuthen (not reading bugmail) 2011-04-02 19:11:17 UTC 
Comment on attachment 184942 [details] [review]
646420 -

Looks good to me. Thanks.