After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646180 - Background preview image is fuzzy
Background preview image is fuzzy
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-30 03:48 UTC by Cosimo Cecchi
Modified: 2011-03-30 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: don't use the GnomeBG thumbnails for the preview area (6.32 KB, patch)
2011-03-30 03:49 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-03-30 03:48:49 UTC 
The image preview in the background panel is not crisp clear.
Attached patch fixes this by calling gnome_bg_draw() directly to render the preview.
Comment 1 Cosimo Cecchi 2011-03-30 03:49:38 UTC 
Created attachment 184648 [details] [review]
background: don't use the GnomeBG thumbnails for the preview area

Instead, use gnome_bg_draw(), which renders the preview directly at the
desired size.
Comment 2 Bastien Nocera 2011-03-30 08:21:45 UTC 
Review of attachment 184648 [details] [review]:

I'm pretty sure this would break whatever little support we have for slideshows.

Add a big fat FIXME in cc_background_item_get_frame_thumbnail() and we'll work on that for 3.2. And please request freeze break for this, the release-team is probably getting sick of me by now.
Comment 3 Matthias Clasen 2011-03-30 11:29:57 UTC 
No, Bastien. We still love you.
Comment 4 Cosimo Cecchi 2011-03-30 13:48:43 UTC 
(In reply to comment #2)
 
> I'm pretty sure this would break whatever little support we have for
> slideshows.

This doesn't break preview for slideshows; it will always show the current frame of the slideshow as preview.
Comment 5 Bastien Nocera 2011-03-30 14:04:29 UTC 
(In reply to comment #4)
> (In reply to comment #2)
> 
> > I'm pretty sure this would break whatever little support we have for
> > slideshows.
> 
> This doesn't break preview for slideshows; it will always show the current
> frame of the slideshow as preview.

Where we used to show the first frame of the slideshow (for better or for worse).
Comment 6 Cosimo Cecchi 2011-03-30 14:12:16 UTC 
(In reply to comment #5)
 
> Where we used to show the first frame of the slideshow (for better or for
> worse).

Yeah, I don't think this makes it a real difference for 3.0 (and we don't even ship slideshows by default in gnome-backgrounds nowadays it seems).
Comment 7 Bastien Nocera 2011-03-30 14:34:37 UTC 
(In reply to comment #6)
> (In reply to comment #5)
> 
> > Where we used to show the first frame of the slideshow (for better or for
> > worse).
> 
> Yeah, I don't think this makes it a real difference for 3.0 (and we don't even
> ship slideshows by default in gnome-backgrounds nowadays it seems).

I didn't say it was a big problem, I said that we need to have a big fat warning in that piece of code to mention that it needs fixing for slideshow stepping, which it will do.
Comment 8 Cosimo Cecchi 2011-03-30 14:43:09 UTC 
Pushed to master with a bigger FIXME comment, after approval from r-t.

Attachment 184648 [details] pushed as 7cef6dc - background: don't use the GnomeBG thumbnails for the preview area