GNOME Bugzilla – Bug 645659
Basic aesthetic improvements to preferences dialog
Last modified: 2011-04-06 21:25:17 UTC
The following set of patches perform some basic aesthetic improvements to the anjuta preferences dialog. More are probably still needed, but this is a start. Snip from email to devel list: Hi, I wanted to familiarize myself with the Anjuta code-base this evening. I thought the best way to do so was to dig in and fix a few things in the UI that looked a little rough. I've attached some before and after screen-shots along with the patches. I tried to split them up in a way that you can cherry pick what you are interested in (if at all). In this patch set, I tackled the following: * Add "primary-toolbar" to the anjuta window. * Adjust preferences dialog so that Close button and dialog contents outer lines are aligned appropriately. Also make sure close button does not collide with window resize grip. * Alter layout of Installed Plugins page to maximize vertical space. * Alter padding and alignments within shortcuts page to match others.
Created attachment 184213 [details] [review] Adjust outer borders of preferences dialog. The preferences dialog had an improper border in that it caused the window resize grips to collide with the close button. While not one to cite the Gnome HIG often, I think the typical 12 pixel border looks rather good here. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Created attachment 184214 [details] [review] Hide vertical scrollbar in preferences unless needed The vertical scrollbar can be somewhat of an eye-sore. It is likely that most users have enough plugins enabled to where they will see it, but I don't think it hurts to disable by default. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Created attachment 184215 [details] [review] Expand text renderer in plugin treeview. Selected items has an interesting looking focus grip around them because the cell renderer did not expand to the visible area. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Created attachment 184216 [details] [review] Ellipsize plugin labels and remove horizontal scrollbar This ellipsizes the plugin label at the end using PANGO_ELLIPSIZE_END. If a plugin title is really long; showing the user important information, there should be an about button like Gedit and libpeas provide; as this is not the proper place to find said information. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Created attachment 184217 [details] [review] Remove headers on plugin list The plugin list headers provide nothing that isn't completely obvious to the user. Additionally, it wastes space and detracts from what the user is trying to do, enable or disable plugins. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Created attachment 184218 [details] [review] Enable rules hint on plugins list When many plugins are available, lack of rules hinting can make it hard to focus on a particular line. This enables the hint for themes that wish to support it. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Created attachment 184219 [details] [review] Alter styling and position of "show all plugins" checkbox The checkbox to show all Anjuta plugins previously was placed at the top of the notebook page. This detracted from what the user is trying to do and can steal users eye focus. Additionally, the amount of padding allocated for said checkbox stole valuable vertical space from the plugin list. This changeset borrows design from the keyboard shortcut list in the gnome-control-center. It uses a toolbar at the bottom of the treeview that looks attached to the treeview. The checkbox is placed within a toolitem in the toolbar. This saves valuable vertical space and allows the user to more easily focus on the plugin list. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Created attachment 184220 [details] [review] Center "Visible" column header text The previous alignment of 0.0f looked somewhat off when the column separator lines are visible. This centers the column title which additionally aligns it better with the checkboxes. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Created attachment 184221 [details] [review] Match border and styling for shortcuts to plugin list Copies the border and styling used in the plugin list to the keyboard shortcuts. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Created attachment 184222 [details] [review] Use GTK_STYLE_CLASS_INLINE_TOOLBAR instead of "inline-toolbar". Quick fix for a poor attempt at a quick patch. Should have fixed this earlier. Signed-off-by: Christian Hergert <chris@dronelabs.com>
Thanks a lot for the patches, I have applied them in master and gnome-3-0