Created attachment 184165 [details] [review]
telepathyClient: fix duplicate copy of first message in a chat

The chat-history-fill-in code had logic to avoid appending two
messages when a message appeared in both the log and the pending
messages. But it wasn't working because of an incorrect object field
name.

Additionally, the code was previously keeping the copy of the message
from the log, and suppressing the copy from pending. But that meant
that once the previous bug was fixed, it would think it had only shown
old messages, and so it would create a source but not notify it. So
fix it to suppress the log message and show the pending message.

Comment on attachment 184165 [details] [review]
telepathyClient: fix duplicate copy of first message in a chat

lost in the bugzilla outage:

--- Comment #2 from Jasper St. Pierre <jstpierre@mecheye.net> 2011-03-24 11:03:31 UTC ---
Review of attachment 184165 [details] [review]:
 --> (https://bugzilla.gnome.org/review?bug=645612&attachment=184165)

LGTM, rah rah freeze break

--- Comment #3 from Jasper St. Pierre <jstpierre@mecheye.net> 2011-03-24 11:05:34 UTC ---
Review of attachment 184165 [details] [review]:
 --> (https://bugzilla.gnome.org/review?bug=645612&attachment=184165)

::: js/ui/telepathyClient.js
@@ +249,2 @@
+        let pendingTpMessages = this._channel.get_pending_messages();
+        let pendingMessages = pendingTpMessages.map(function (tpMessage) {
return makeMessageFromTpMessage(tpMessage, NotificationDirection.RECEIVED); });

style nit: break into multiple lines

Review of attachment 184165 [details] [review]:

Sign off from me and +2 from release team
http://mail.gnome.org/archives/release-team/2011-March/msg00360.html

Attachment 184165 [details] pushed as d2de086 - telepathyClient: fix duplicate copy of first message in a chat