After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645536 - Should use icons from the icon theme
Should use icons from the icon theme
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Other Preferences
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-22 14:59 UTC by Cosimo Cecchi
Modified: 2011-09-01 14:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome power manager launcher icon (visible in system settings) (76.12 KB, application/zip)
2011-03-22 15:58 UTC, Jakub Steiner 		  Details
point to the right icon (866 bytes, patch)
2011-08-31 14:40 UTC, Jakub Steiner 		none Details | Review
actually the icon is no longer shipping with gnome-power-manager, so include it. (59.49 KB, patch)
2011-08-31 15:48 UTC, Jakub Steiner 		committed Details | Review

Description Cosimo Cecchi 2011-03-22 14:59:13 UTC 
Instead of shipping its own icons.

This is related to https://bugzilla.gnome.org/show_bug.cgi?id=645535
Comment 1 Richard Hughes 2011-03-22 15:33:49 UTC 
g-p-m uses lots of icons not present in the theme -- Jakub didn't want device specific icons in the theme last time I asked. For instance, we'd need keyboard icons, mouse icons and ups icon sets. If they were added to g-i-t then I would gladly switch.
Comment 2 Jakub Steiner 2011-03-22 15:53:00 UTC 
We should just update the gpm system settings icon rather than using the charge status ones as Lapo seems to have suggested on IRC.
Comment 3 Jakub Steiner 2011-03-22 15:58:54 UTC 
Created attachment 184091 [details]
gnome power manager launcher icon (visible in system settings)
Comment 4 Richard Hughes 2011-03-22 16:08:38 UTC 
Either is good for me, but you'll have to get release team approval as that's going to change the UI and mess up any existing screenshots.
Comment 5 Akhil Laddha 2011-04-08 04:41:02 UTC 
Can changes be committed in 3.1.x ?
Comment 6 Richard Hughes 2011-04-26 11:33:19 UTC 
(In reply to comment #5)
> Can changes be committed in 3.1.x ?

Yup, please commit to git master. Thanks.
Comment 7 Akhil Laddha 2011-06-15 05:48:50 UTC 
Jakub, Cosimo, could you please commit changes in master branch as per comment#6, tia.
Comment 8 Jakub Steiner 2011-06-15 09:14:20 UTC 
pushed to master.
Comment 9 Jakub Steiner 2011-08-31 14:37:58 UTC 
Turns out the icon that the panel looks up is still battery-good-charging. Attaching a patch and changing module.
Comment 10 Jakub Steiner 2011-08-31 14:40:26 UTC 
Created attachment 195306 [details] [review]
point to the right icon
Comment 11 Jakub Steiner 2011-08-31 15:48:42 UTC 
Created attachment 195312 [details] [review]
actually the icon is no longer shipping with gnome-power-manager, so include it.
Comment 12 Bastien Nocera 2011-09-01 09:56:38 UTC 
Comment on attachment 195312 [details] [review]
actually the icon is no longer shipping with gnome-power-manager, so include it.

Makefile.am files are missing from the patch.
Comment 13 Bastien Nocera 2011-09-01 14:36:36 UTC 
Committed with a few commit message tweaks, and configure.ac paths fixes.