After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645283 - Keyboard preview dialog needs a name
Keyboard preview dialog needs a name
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Capplet
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
[gnome3-important]
Depends on:
Blocks:
 
 
Reported: 2011-03-20 06:08 UTC by William Jon McCann
Modified: 2011-03-22 20:56 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
screenshot (568.23 KB, image/png)
2011-03-20 06:08 UTC, William Jon McCann 		  Details
Categorize gkbd-keyboard-display.desktop (1.03 KB, patch)
2011-03-22 14:26 UTC, Colin Walters 		none Details | Review

Description William Jon McCann 2011-03-20 06:08:10 UTC 
Created attachment 183840 [details]
screenshot

When launching the "Show Keyboard Layout..." menu item in the shell I get the attached.
Comment 1 William Jon McCann 2011-03-20 06:08:50 UTC 
The AppMenu name is wrong.
Comment 2 William Jon McCann 2011-03-20 06:37:55 UTC 
Hmm desktop file seems to be installed and match the WM_CLASS. Colin, any ideas?
Comment 3 William Jon McCann 2011-03-22 05:28:20 UTC 
Colin, any ideas?  We should really try to fix this since it is launched from within the shell.
Comment 4 Colin Walters 2011-03-22 14:13:04 UTC 
Type this in lg:

Shell.AppSystem.get_default().get_app('gkbd-keyboard-display.desktop')

It returns null for me, which means we're not finding the app.  It's some menu categorization problem.
Comment 5 Colin Walters 2011-03-22 14:16:30 UTC 
Yep, adding "System;" to its Categories picks it up.

There is no menu that includes "Categories=GNOME;GTK;Core;" right now.
Comment 6 Colin Walters 2011-03-22 14:26:57 UTC 
Created attachment 184066 [details] [review]
Categorize gkbd-keyboard-display.desktop

In order to have the shell show it, it needs to "in theory" be
in a menu, even if it's NoDisplay=true.  "GNOME;Gtk;Core;" isn't
shown anywhere, so stick it in "System Tools".
Comment 7 Sergey V. Udaltsov 2011-03-22 20:56:35 UTC 
Cool! Thanks, committed.