GNOME Bugzilla – Bug 645133
Set 'extra-identities' for Google Talk accounts
Last modified: 2013-03-29 10:31:58 UTC
When creating google talk accounts, allow 'talk.google.com' as an extra identity for server certificate validation. See https://bugs.freedesktop.org/show_bug.cgi?id=35415 for the gabble implementation. This has the result of adding it to the list of reference identities used by empathy-auth-client to check the server certificate host name.
Implemented here: http://git.collabora.co.uk/?p=user/stefw/empathy.git;a=shortlog;h=refs/heads/extra-identities
Code actually depend on bug #645119, but resulting functiontality does.
Created attachment 183721 [details] [review] Implementation
Looks good. Are you still able to connect if the CM doesn't implement this property? Also, it would be great if you could do a similar branch based on top of 2.34. You'll have to modify src/empathy-account-assistant.c and src/empathy-accounts-dialog.c and the factor out of this code is not in 2.34.
No, can't connect if the connection manager doesn't have this property. How would I make that work?
As discussed on IRC, we should only set this param if we know that the CM supports it.
Done. Check if 'extra-identities' is supported by the CM: http://git.collabora.co.uk/?p=user/stefw/empathy.git;a=commit;h=8cd67a0111d6b6273ca37bba0bd0afe3f7142fe2
Can you please record the add empathy_account_settings_have_tp_param() change as a separated patch? Except that looks good. Can you please provide an equivalent branch for 2.34?
Created attachment 183921 [details] [review] Check that extra-identities is supported by gabble.
Created attachment 183925 [details] [review] Updated implementation Changed 'extra-identities' to 'extra-certificate-identities' to match commit in gabble.
Could you please record one patch adding the empathy_account_settings_have_tp_param() function and another one the 'extra-certificate-identities' change. That would make backport to 2.34 easier. :)
Merged into master. Will attach gnome-2-34 relevant patches.
I found this bug based on string param-extra-certificate-identities because I was researching bug https://bugzilla.redhat.com/show_bug.cgi?id=928913 It appears the extra identity name isn't being used by empathy 3.8.0 on fedora 19, instead empathy uses "gmail.com" as the name to verify against, and fails. The above fedora bug has more information.
Kai, the issue on Fedora 19 was a bug in p11-kit which is now fixed.