GNOME Bugzilla – Bug 645089
"Include a Delete command" string is confusing
Last modified: 2015-02-28 20:21:50 UTC
"I_nclude a Delete command that bypasses Trash" Most users probably won't understand what a Delete command is, a better line would be: "Bypass Trash and delete files directly" Or something to that effect.
It's too late to change this for 3.0, as we're in string freeze now, but I agree the wording is not optimal. Although, your suggestion is not good either, as we don't delete files by default when that option is active, we just add a "Delete" menu item and make Shift+Canc activate it.
Ok now i think i understand what it does. How about: "Add a Delete menu option that bypasses Trash"
I am a beginner and i want to work on it.
Avinash: Great! Looking forward to your patch - see https://wiki.gnome.org/Git/Developers And the string still exists in the current codebase: #: ../src/nautilus-file-management-properties.ui.h:21 msgid "I_nclude a Delete command that bypasses Trash"
Andre: How can i contact you on IRC as it is my first bug so i have many doubts regarding this.
You don't. You just ask a specific question on IRC (#gnome-love) and wait for *anybody* to answer. :)
Created attachment 290787 [details] [review] Replace the confusing string with an appropriate string. I have changed the confusing string. Can anyone review this patch for me and tell me if it requires any rectification. Thank you.
Looks good to me :)
Review of attachment 290787 [details] [review]: As we already talked on IRC, probably this sentence doesn't improve too much. The difference between: "I_nclude a Delete command that bypasses Trash" and "Add a Delete menu option that bypasses Trash" are very subtle. "add" instead of "include", "menu option" instead of "command". So probably better to ask to designers. On the technical side, the commit message doesn't has a correct style, see: https://wiki.gnome.org/GnomeLove/CodeContributionWorkflow#Commit_guidelines Feel free to update the patch with the technical parts fixed. ::: src/nautilus-file-management-properties.ui @@ +681,3 @@ <child> <object class="GtkCheckButton" id="trash_delete_checkbutton"> + <property name="label" translatable="yes">Add a Delete menu option that bypasses Trash</property> There is no mnemonic in this one (the underscore character). Make sure it doesn't collide with other mnemonics in the same page.
Created attachment 291015 [details] [review] Added an appropriate and meaningful string. The old string is a bit confusing and most users won't understand it. so a new string is added in place of the old one so that all users can understand the actual meaning.
Comment on attachment 291015 [details] [review] Added an appropriate and meaningful string. There is still no mnemonic.
Review of attachment 291015 [details] [review]: Apart from what Andre said, that there's still no mnemonic, the commit message still doesn't follow the guidelines (the wiki is faulty in that part, I will correct it). You have to put the file affected in the short description, take a look on this commit for example https://git.gnome.org/browse/nautilus/commit/?id=17061d58d126077a26dd44595c321ee134f5747c Also the tense of the verb has to be present, so you have to say "Add" instead of "Added".
Created attachment 298140 [details] [review] Replace confusing string
I wonder why we need this option at all. We could just always enable Shift-Delete. After all, it does have a confirmation dialog. Whats the harm ?
(In reply to Matthias Clasen from comment #14) > I wonder why we need this option at all. We could just always enable > Shift-Delete. After all, it does have a confirmation dialog. Whats the harm ? More than the harm, is having another menu item that can be easily trigered etc. What we can do is remove the menu item and allow the shortcut always.
Review of attachment 298140 [details] [review]: The code looks good, wait until we reach a decision on what to do with the option tho. Thanks for the work!
Created attachment 298188 [details] [review] nautilus-view: always allow to permanently delete Before 3.15 we had a setting for adding a menu item for permanent deletion of files. But the shortcut was always enabled no matter the state of the setting, which seems inconsistent. Then with the GAction port we changed that behavior to be consistent, but people that were unaware of the setting were complaining that the shortcut for permanent deletion was not working. Given that we show a dialog if we hit that shortcut, and the setting itself is confusing, just enable always the shortcut but remove the setting and the menu item for it.
Thinking more about it and given the bug https://bugzilla.gnome.org/show_bug.cgi?id=745321, I agree with you Mathias. I attached the patch here by accident, 745321 is the good one.