After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645037 - "You're now" in networking strings
"You're now" in networking strings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-17 15:37 UTC by Frederic Peters
Modified: 2011-09-14 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network-status: Remove colloquialism in string (1.18 KB, patch)
2011-09-07 12:06 UTC, Florian Müllner 		committed Details | Review

Description Frederic Peters 2011-03-17 15:37:44 UTC 
Typo at:

#: ../js/ui/status/network.js:1807
msgid "Connection estabilished"

Many "You're now", instead of "You are now":

#: ../js/ui/status/network.js:1799 (for example)
msgid "You're now connected to '%s'"
Comment 1 Owen Taylor 2011-03-31 19:03:55 UTC 
first was fixed by:

commit 8ab25de6c6d9f0270d1145ef16a9ebb65f5e7490
Author: Wouter Bolsterlee <wbolster@gnome.org>
Date:   Sat Mar 19 01:16:16 2011 +0100

    Fix user visible typo: s/estabilished/established/
    
    The affected translations are also modified to not cause any
    inconvenience for translators.

"You're now" would be 3.2 material for changing.
Comment 2 Giovanni Campagna 2011-04-02 18:29:25 UTC 
(In reply to comment #1)
> first was fixed by:
> 
> commit 8ab25de6c6d9f0270d1145ef16a9ebb65f5e7490
> Author: Wouter Bolsterlee <wbolster@gnome.org>
> Date:   Sat Mar 19 01:16:16 2011 +0100
> 
>     Fix user visible typo: s/estabilished/established/
> 
>     The affected translations are also modified to not cause any
>     inconvenience for translators.
> 
> "You're now" would be 3.2 material for changing.

Actually, this would be fine in 3.0, because those strings are never shown anywhere (they're for the notifications, which are suppressed because nm-applet is running)
Comment 3 Florian Müllner 2011-09-07 12:06:11 UTC 
Created attachment 195859 [details] [review]
network-status: Remove colloquialism in string

The original offenders are no longer present, but a new one sneaked in; not sure it is worth to get a freeze break exception for this (though we could adjust existing translations to make it less painful).
Comment 4 drago01 2011-09-09 16:16:15 UTC 
Review of attachment 195859 [details] [review]:

Fine ... not sure about the freeze hence "commit_after_freeze".
Comment 5 Florian Müllner 2011-09-09 16:41:11 UTC 
(In reply to comment #4)
> Review of attachment 195859 [details] [review]:
> 
> Fine ... not sure about the freeze hence "commit_after_freeze".

It modifies an existing msgid, so it definitively affects the freeze. I already included this patch in a freeze break request[0] (after getting a quick IRC review of the patch).


[0] https://mail.gnome.org/archives/gnome-i18n/2011-September/msg00118.html
Comment 6 Florian Müllner 2011-09-14 13:45:41 UTC 
Attachment 195859 [details] pushed as e81cee3 - network-status: Remove colloquialism in string

Pushed after freeze break approval.