GNOME Bugzilla – Bug 644668
Always use an application icon
Last modified: 2011-03-20 05:54:49 UTC
We should never show an empty space instead of an icon (neither in the dash, application view or altTab). In case the app does not provide an icon for whatever reason we should just show a generic one like application-x-executable as suggested by the designers.
Created attachment 183602 [details] [review] Fallback to using a generic when requested image isn't found Use a type specific generic image when the requested icon can't be loaded instead of using an empty texture. It is better not to use gicon theme fallbacks so that the built-in fallbacks work as intended, so that non-themed icons work too, and so that textures can be cached efficiently.
Review of attachment 183602 [details] [review]: I am confused by the code duplication here, but clearly you didn't create that situation. It looks to me like we're basically trying to handle non-themed icons inside ShellAppSystem which have absolute paths like /path/to/my/app.png. ::: src/shell-app-system.c @@ +1216,3 @@ + G_OBJECT (info->window), + "icon"); + goto out; I'm not sure if there is a strict rule about this, but I really dislike seeing "goto" for anything *except* exception unwinding, and this doesn't really fit. This could be written as if (info == _WINDOW) { } else { } just fine.
Created attachment 183638 [details] [review] Fallback to using a generic when requested image isn't found Use a type specific generic image when the requested icon can't be loaded instead of using an empty texture.
Attachment 183638 [details] pushed as dd99ed7 - Fallback to using a generic when requested image isn't found
*** Bug 639248 has been marked as a duplicate of this bug. ***