After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644541 - Don't show the overview on start
Don't show the overview on start
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-11 23:40 UTC by Owen Taylor
Modified: 2011-03-12 00:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't show the overview on start (1.98 KB, patch)
2011-03-11 23:40 UTC, Owen Taylor 		none Details | Review
Don't show the overview unless removing the workspace (1.52 KB, patch)
2011-03-12 00:03 UTC, Owen Taylor 		none Details | Review
Don't show the overview unless removing the workspace (1.89 KB, patch)
2011-03-12 00:05 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2011-03-11 23:40:19 UTC 
When starting the shell with no windows, we'd enter the overview
because it looked the same as closing the last window. This
was unintentional, so fix by only entering the overview if we've
actually closed windows.
Comment 1 Owen Taylor 2011-03-11 23:40:21 UTC 
Created attachment 183182 [details] [review]
Don't show the overview on start
Comment 2 Owen Taylor 2011-03-12 00:03:39 UTC 
Created attachment 183184 [details] [review]
Don't show the overview unless removing the workspace

Don't enter the overview at startup, or when we we remove the
last window on the first workspace, but only when we remove a
desktop and there are windows on other workspaces.
Comment 3 Owen Taylor 2011-03-12 00:05:43 UTC 
Created attachment 183185 [details] [review]
Don't show the overview unless removing the workspace

What I meant to attach
Comment 4 drago01 2011-03-12 00:18:38 UTC 
Review of attachment 183185 [details] [review]:

The code looks good and this is IMO the better option.
As noted on IRC the commit message reads better when writing that as 'on the other workspaces' (and stick to either desktops or workspaces).

Otherwise fine assuming no objections from the designers.
Comment 5 Owen Taylor 2011-03-12 00:22:04 UTC 
Attachment 183185 [details] pushed as 8a28022 - Don't show the overview unless removing the workspace