Created attachment 183175 [details] [review]
session: Change XSMP restart style to Never

See also work in https://bugzilla.gnome.org/show_bug.cgi?id=642497

Comment on attachment 183175 [details] [review]
session: Change XSMP restart style to Never

>+    char hint = SmRestartNever;

SmRestartNever means that even if the user has session saving enabled, mutter/gnome-shell will not save its state, and so window geometry will not be saved between sessions.

If that's not what you intended, then you meant SmRestartIfRunning.

If that is what you intended, then you should get rid of all of the session saving support, since it will be dead code. At that point you should probably also get rid of libSM and use the gnome-session D-Bus interface instead.

Created attachment 183340 [details] [review]
session: Don't set XSMP restart

This made sense back in the day of stateless window managers,
but gnome-shell isn't.  gnome-session will handle gnome-shell
crashing, since it's a required component.

Comment on attachment 183340 [details] [review]
session: Don't set XSMP restart

It does what it says it does, though I'm not convinced about the logic. I can't think why any libmutter user would not want to be restarted on crash.

meta_session_shutdown() is a no-op now.

(In reply to comment #5)
> (From update of attachment 183340 [details] [review])
> It does what it says it does, though I'm not convinced about the logic. I can't
> think why any libmutter user would not want to be restarted on crash.

Any libmutter user (i.e. gnome-shell) can hook into gnome-session differently to handle restarting in a better way - see the bug I linked above:
https://bugzilla.gnome.org/show_bug.cgi?id=642497

(Basically there is a "Try Recovery" button in this case)

> meta_session_shutdown() is a no-op now.

Ok, will remove.

Attachment 183340 [details] pushed as 3cd0e86 - session: Don't set XSMP restart