After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644348 - notebook: make GtkNotebook respect the focus-padding style property
notebook: make GtkNotebook respect the focus-padding style property
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-03-09 21:40 UTC by Cosimo Cecchi
Modified: 2011-03-14 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
notebook: make GtkNotebook respect the focus-padding style property (1.54 KB, patch)
2011-03-09 21:40 UTC, Cosimo Cecchi 		none Details | Review
notebook: make GtkNotebook respect the focus-padding style property (7.85 KB, patch)
2011-03-14 15:03 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-03-09 21:40:49 UTC 
It seems GtkNotebook doesn't respect the focus-padding style property when rendering the focus. This patch fixes it.
Comment 1 Cosimo Cecchi 2011-03-09 21:40:51 UTC 
Created attachment 183028 [details] [review]
notebook: make GtkNotebook respect the focus-padding style property
Comment 2 Matthias Clasen 2011-03-09 21:48:04 UTC 
Review of attachment 183028 [details] [review]:

Looks good as far as the drawing is concerned (without trying it). Do we need to adjust allocation for this, too ?
Comment 3 Cosimo Cecchi 2011-03-14 15:03:54 UTC 
Created attachment 183348 [details] [review]
notebook: make GtkNotebook respect the focus-padding style property

Updated patch which fixes also size-request and size-allocate impls.
Fixes also some inconsistencies in handling focus-line-width.
Comment 4 Matthias Clasen 2011-03-14 15:52:47 UTC 
Works fine in brief testing. Please commit to master and gtk-3-0
Comment 5 Cosimo Cecchi 2011-03-14 16:00:00 UTC 
Attachment 183348 [details] pushed as c9f38ba - notebook: make GtkNotebook respect the focus-padding style property