Created attachment 182654 [details] [review]
0001-build-improve-CUPS-detection.patch

I agree that using cups-config is an improvement, but awk instead of sed seems like a lateral move...

The improvement in that case is 2 execs -> 1 exec.  It's also a lot more clear whats happening.  But, feel free to view it as a lateral move :-).

(In reply to comment #3)
> The improvement in that case is 2 execs -> 1 exec.  It's also a lot more clear
> whats happening.  But, feel free to view it as a lateral move :-).

Could you please remake this patch, as well as the one against gnome-settings-daemon to use sed instead?

Sure, though, can you give a reason as to why sed is preferred over awk when the awk is simpler?

Because I can maintain sed scripts, not awk ones.

Created attachment 183199 [details] [review]
0002-build-use-sed-instead-of-awk.patch

Fair enough, attached is a supplementary patch that uses sed.  FWIW, the majority of the GNOME modules that checked the DBus version also used awk as it so happens, but the maintainence argument is valid.

Created attachment 183200 [details] [review]
0002-build-use-cut-instead-of-awk.patch

This is an alternative btw, that uses cut instead of sed.

Created attachment 183203 [details] [review]
0002-build-use-sed-instead-of-awk.patch

Hopefully the correct version this time.

I like the cut patch better (from comment 8), could I please get the changes squashed into one patch?

Squashed the 2 patches together