After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643934 - GApplication lacking a logical dual for the ::startup signal
GApplication lacking a logical dual for the ::startup signal
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gapplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-03-05 08:34 UTC by Brian Koning
Modified: 2011-09-14 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch introducing ::shutdown for gapplication.c/h (3.36 KB, patch)
2011-03-05 08:34 UTC, Brian Koning 		none Details | Review
GApplication: introduce ::shutdown (3.60 KB, patch)
2011-09-14 17:43 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Brian Koning 2011-03-05 08:34:09 UTC 
Created attachment 182535 [details] [review]
Patch introducing ::shutdown for gapplication.c/h

GApplication's ::startup signal is convenient place to fully initialize a Primary instance. What is missing is the logical duel to undo the actions preformed in ::startup. Enter the ::shutdown signal. The signal is emitted only when the GApplication is registered immediately after the mainloop attempts to run.

I have prepared two patches making the necessary changes for the ::shutdown signal.
Comment 1 Allison Karlitskaya (desrt) 2011-09-14 17:43:32 UTC 
Created attachment 196529 [details] [review]
GApplication: introduce ::shutdown

Introduce ::shutdown as a dual to ::startup.
Comment 2 Allison Karlitskaya (desrt) 2011-09-14 17:44:23 UTC 
The only change was to move the shutdown pointer to the end of the vtable to avoid the ABI change.
Comment 3 Allison Karlitskaya (desrt) 2011-09-14 17:47:31 UTC 
Thanks for the suggestion, Brian (and for the patch).