After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643914 - Area under tabs need its own style class
Area under tabs need its own style class
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkNotebook
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 707920
 
 
Reported: 2011-03-04 22:14 UTC by Cosimo Cecchi
Modified: 2013-09-27 03:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.05 KB, patch)
2011-03-05 18:52 UTC, Cosimo Cecchi
accepted-commit_now Details | Review

Description Cosimo Cecchi 2011-03-04 22:14:26 UTC
The rectangle under the tabs needs a different style class so that it can be themed separately from the rest of the notebook. I think GTK_STYLE_CLASS_HEADER would be a good candidate.
Comment 1 Cosimo Cecchi 2011-03-05 18:52:37 UTC
Created attachment 182567 [details] [review]
patch

Proposed patch; renders a background and frame in the header.
Comment 2 Matthias Clasen 2011-03-06 06:39:58 UTC
Maybe this should be a region instead ?
Best to discuss with garnacho
Comment 3 Carlos Garnacho 2011-03-08 18:59:18 UTC
Not sure of the usecase for this :), if it's meant to cover all the area behind the tabs, using a class makes sense to me, :nth-child() doesn't apply much in that case.
Comment 4 Cosimo Cecchi 2011-03-08 19:35:10 UTC
(In reply to comment #3)
> Not sure of the usecase for this :), if it's meant to cover all the area behind
> the tabs, using a class makes sense to me, :nth-child() doesn't apply much in
> that case.

Yes, it's meant to give themes a way to override the background color of the area under the tabs. For instance, we could use this gradient with 1px of white at the top in GEdit.

[1] http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/theming/toolbars.png
Comment 5 Lapo Calamandrei 2012-11-14 15:30:06 UTC
I'd like the ability to add a top border in case there's a primary toolbar on top here (since I'd like to get rid of the bottom border of toolbars), the region approach (.notebook something{})for what I can understand shouldn't break existing themes also, hence innocuous, right?
Comment 6 Matthias Clasen 2013-09-26 21:12:51 UTC
Review of attachment 182567 [details] [review]:

looks fine to me
Comment 7 Matthias Clasen 2013-09-26 22:06:52 UTC
Review of attachment 182567 [details] [review]:

but maybe we should only do this if show_tabs is true ?