GNOME Bugzilla – Bug 643914
Area under tabs need its own style class
Last modified: 2013-09-27 03:39:27 UTC
The rectangle under the tabs needs a different style class so that it can be themed separately from the rest of the notebook. I think GTK_STYLE_CLASS_HEADER would be a good candidate.
Created attachment 182567 [details] [review] patch Proposed patch; renders a background and frame in the header.
Maybe this should be a region instead ? Best to discuss with garnacho
Not sure of the usecase for this :), if it's meant to cover all the area behind the tabs, using a class makes sense to me, :nth-child() doesn't apply much in that case.
(In reply to comment #3) > Not sure of the usecase for this :), if it's meant to cover all the area behind > the tabs, using a class makes sense to me, :nth-child() doesn't apply much in > that case. Yes, it's meant to give themes a way to override the background color of the area under the tabs. For instance, we could use this gradient with 1px of white at the top in GEdit. [1] http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/theming/toolbars.png
I'd like the ability to add a top border in case there's a primary toolbar on top here (since I'd like to get rid of the bottom border of toolbars), the region approach (.notebook something{})for what I can understand shouldn't break existing themes also, hence innocuous, right?
Review of attachment 182567 [details] [review]: looks fine to me
Review of attachment 182567 [details] [review]: but maybe we should only do this if show_tabs is true ?