GNOME Bugzilla – Bug 643873
Incomplete loading of graphs from xlsx
Last modified: 2011-12-27 14:47:54 UTC
Created attachment 182465 [details] XL2003 screen snapshot http://www.autoobserver.com/car-data-center/assets/2011-03%20Sales.xlsx The graphs in gnumeric are basically blank. The attached snapshot shows what xl gets out of the file.
Thanks. The issue is the same as #643874. Of course we might use the saved values instead of the expression, but it would be a bug in itself (it might be useful for external references, but it is not the case).
Created attachment 182520 [details] [review] Ugly patch /me creates a link to bug 643874. Ugly patch that does the job. We actually get data in the charts!
Created attachment 182521 [details] [review] Whole patch, still ugly Previous patch was incomplete.
At least things work. I'm not enough expert to see the ugly aspect.
"ugly": lexing these need to go into the conventions. Stangely only the middle graph has titles in Gnumeric.
That's because the other graphs use formulas and they are just dropped for now, I'll (try to) fix that.
Titles should now appear in all charts.
Strange that some columns look like if there were some pattern at work in excel. The file only has solidFill, no pattFill.
Jean: details like that could be related to the translation that my xl (2003?) claims is going on when loading the file.
Might be because 2003 did not support the alpha value.
I still get... > MarketShare!P70 : Unknown color 'bg1' ... > MarketShare!P70 : Dropping missing object ...but XL shows nothing there either.
'bg1' is one of excel theme colors as far as I understand it. I don't know which color it is really. The missing object thing worries me a bit more. I'll try to understand what it is.
Created attachment 182811 [details] [review] warnings fix. We just don't create any sheet object, that's why we get the warning. The location is wrong since we do not set state->pos while loading drawings, so it is the last cell instead. This patch does not fix all is has some weirdness, anyway error messages are gone. Still need to really load the image and the various objects styles.
Created attachment 183024 [details] [review] enhanced patch With this patch, there are no more unexpected nodes (nothing is done for most) and it adds basic sheet image import. There are many things that we don't support. Sheet objects need a lot of improvements (the canvas already supports most, if not all, needed things).
Comment on attachment 183024 [details] [review] enhanced patch Commited an enhanced patch
*** Bug 644983 has been marked as a duplicate of this bug. ***
Comment on attachment 182521 [details] [review] Whole patch, still ugly committed. it'll have to be de-uglified later.
Created attachment 184166 [details] [review] Import combo boxes from xlsx. There is a big issue with this patch that I don't understand: expressions and values leaks. What's wrong?
Created attachment 184170 [details] sample barchart file file with 1 barchart and 1 image showing the barcharchart as rendered in Excel
Created attachment 184357 [details] [review] make combo box import acceptable The horizontal position for the controls is not perfect, but with this patch, we are almost at the best that can be done for this sample file without breaking the goffice API.
Comment on attachment 184357 [details] [review] make combo box import acceptable There is nothing more that can be done for now without breaking goffice API. Enhancements needed for the future: data labels (I have a partial patch for that), and enhanced GogLabel (fixed width, alignment, wrapping,...).
If I try to open ./samples/excel12/chart-tests-excel.xlsx the graphs don't like correct at all (each of them is a tiny plot inside a significantly larger graph object).
Hmm, I actually know that. It's a size issue. I hope I can find some time next week to fix that.
Created attachment 194401 [details] screen shot of the first file
Created attachment 194402 [details] screenshot of the barchart file
Import of data labels is now much better. There are size inconsistencies, but the file set the size for some labels, but not all. Need to wrap the labels now.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report. Not perfect, but not so bad. We don't export such charts to xlsx (or even xls) at the moment.