Created attachment 182427 [details] [review]
workspace: Move close button to the left in RTL locales

Mutter reverses the button layout in RTL locales, so we should do
the same for the window previews' close buttons.

Review of attachment 182427 [details] [review]:

good to commit except for a style issue

::: js/ui/workspace.js
@@ +423,3 @@
         let buttonY = cloneY - button.height + button._overlap;
+        if (St.Widget.get_default_direction() == St.TextDirection.RTL)
+            buttonX = cloneX - (button.width - button._overlap);

While I think this is clearer with the parens, it's pretty weird to have:

 buttonY = cloneY - button.height + button._overlap;
 buttonX = cloneX - (button.width - button._overlap);

so change one or the other

(In reply to comment #2)
> While I think this is clearer with the parens, it's pretty weird to have:
> 
>  buttonY = cloneY - button.height + button._overlap;
>  buttonX = cloneX - (button.width - button._overlap);
> 
> so change one or the other

Sure.


Attachment 182427 [details] pushed as cf85477 - workspace: Move close button to the left in RTL locales