Created attachment 182225 [details] [review]
search-display: Remove search result count

Currently the total number of matches for a particular section is
displayed on the left of the section's header. While it made sense
in the old layout where it was close to the section's title, it is
now rather disconnected, and has been removed in current mockups.

Created attachment 182226 [details] [review]
search: Don't expand search when clicking section headers

Currently section headers in the search view are reactive and run
the corresponding provider's expandSearch() function when clicked,
which should launch an external program displaying all search
results for the section. Unfortunately it is only implemented for
the "Settings" provider, and does not work properly (as it ignores
the search and just launches System Settings).
Also current mockups deemphasize the section header, making the
feature pretty much indiscoverable (except by accident when
interfering with swipe-scrolling).
In conclusion, the feature does not make much sense in its current
form, so remove it.

Created attachment 182227 [details] [review]
search: Replace 'icon' property in metaInfo with a function

Search results' meta info currently is expected to have an 'icon'
property holding a Clutter.Texture of a fixed icon size. This
property is used to implement the createIcon() function of BaseIcon,
which is used to actually display the result - the size parameter
of that function being ignored due to the fixed icon size.
Given that all available search providers create this property for
the desired icon size using a function with the same signature, it
appears logical to replace the fixed-sized 'icon' property with
such a function, so that the icon size will be defined by the display
actor rather than the search system.

Created attachment 182228 [details] [review]
search-result: Use a larger icon size

Increase the icon size of search results for consistency with the
application view. To account for the larger icons, only display
a single row of results per section.

Created attachment 182229 [details] [review]
search-display: Minor style updates

Adjust the style of the search display to match current mockups:

 - add a border to search buttons
 - increase padding and spacing
 - remove section background and border
 - decrease font size in section headers

Review of attachment 182225 [details] [review]:

Looks good and makes sense.

Review of attachment 182226 [details] [review]:

Makes sense (while at it I think we should style the section headers differently but that has nothing to do with this patch).

Review of attachment 182227 [details] [review]:

The code looks good but the commit message reads weird "the size parameter of that function being ignored due to the fixed icon size." maybe "ignoring the size parameter due to the fixed icon size" or something like that instead.

Review of attachment 182228 [details] [review]:

Makes sense even though it comes of the cost of displaying less search results, which shouldn't matter much for application search but can be a problem for files. If it becomes a problem we would need design input to fix it anyway so fine for now.

Review of attachment 182229 [details] [review]:

This makes the section headers hardly visible I'd at least make them bold, but well design issue ... the code changes look good.

Looks fab from my side.

Pushed with r-t approval.

Attachment 182225 [details] pushed as 08e0485 - search-display: Remove search result count
Attachment 182226 [details] pushed as 7f51350 - search: Don't expand search when clicking section headers
Attachment 182227 [details] pushed as 7723e59 - search: Replace 'icon' property in metaInfo with a function
Attachment 182228 [details] pushed as 34ce17c - search-result: Use a larger icon size
Attachment 182229 [details] pushed as 84889d6 - search-display: Minor style updates