Bug 643551 – dialog does not go away at session end

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 643551 - dialog does not go away at session end


Summary:	dialog does not go away at session end


Status:	RESOLVED FIXED

Product:	policykit-gnome
Classification:	Platform
Component:	authentication dialog
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	policykit-gnome-maint
QA Contact:	policykit-gnome-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2011-03-01 03:31 UTC by Matthias Clasen
Modified:	2011-03-01 15:45 UTC

See Also:
GNOME target:	3.0
GNOME version:	---

Attachments
patch (601 bytes, patch) 2011-03-01 03:31 UTC, Matthias Clasen	accepted-commit_now	Details \| Review

Description Matthias Clasen 2011-03-01 03:31:31 UTC

Created attachment 182155 [details] [review]
patch

We run polkit-gnome-authentication-agent-1 in the gdm login session. When the user logs in, that is the sole gdm process lingering. The reason is that the agent does not register as a session client, and does not open a connection to the session bus. So it doesn't get killed by gnome-session and does not go away when the session bus dies. And we don't restart the X server between the login session and the user session.

Here is a patch that makes the agent connect to the session bus, which is enough to get it killed at the right time.

Comment 1 David Zeuthen (not reading bugmail) 2011-03-01 11:12:18 UTC

Comment on attachment 182155 [details] [review]
patch

Hmm, I agree this is a problem, but

 - we probably shouldn't run the agent in the gdm session at all

 - gnome-session should probably take care of killing processes
   when the session terminates (systemd?)

 - could be gdm should stay around to do other things - it probably
   should play the role of system compositor

Either way, please commit the patch. Btw, I'm planning to do a release this week...

Comment 2 Matthias Clasen 2011-03-01 15:45:15 UTC

Thanks, committed.