After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643208 - Nautilus crashes when SVG loader is borked
Nautilus crashes when SVG loader is borked
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: All
2.32.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-24 16:53 UTC by Rodrigo Moya
Modified: 2011-02-25 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for gnome-2-32 branch (855 bytes, patch)
2011-02-24 16:53 UTC, Rodrigo Moya 		none Details | Review
Patch for master (855 bytes, patch)
2011-02-24 16:56 UTC, Rodrigo Moya 		reviewed Details | Review

Description Rodrigo Moya 2011-02-24 16:53:03 UTC 
Created attachment 181846 [details] [review]
Patch for gnome-2-32 branch

In Ubuntu there was a problem with the gdk-pixbuf package that didn't register itself correctly to /usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache. This made it fail on the gwibber icon, which is provided only as a SVG in /usr/share/pixmaps. This made gtk_icon_info_get_filename return NULL as 'filename', which was used to search in the hash table (see https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/718098).

Attached patch guards against filename being NULL
Comment 1 Rodrigo Moya 2011-02-24 16:56:02 UTC 
Created attachment 181847 [details] [review]
Patch for master
Comment 2 Cosimo Cecchi 2011-02-24 17:53:41 UTC 
Review of attachment 181847 [details] [review]:

Thanks, I inlined a comment.

::: libnautilus-private/nautilus-icon-info.c
@@ +398,2 @@
 		filename = gtk_icon_info_get_filename (gtkicon_info);
+		if (filename == NULL) {

You should free gtkicon_info before returning here.
Comment 3 Rodrigo Moya 2011-02-25 14:53:28 UTC 
Ok, fixed the leak and pushed to both master and gnome-2-32