After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643118 - "How to choose a strong password": take markup out of translated string
"How to choose a strong password": take markup out of translated string
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
git master
Other All
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 643340 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-23 20:20 UTC by Luca Ferretti
Modified: 2011-04-15 01:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.41 KB, patch)
2011-04-13 01:22 UTC, Matthias Clasen 		committed Details | Review
user-accounts: Don't include link in translation (35.36 KB, patch)
2011-04-13 14:37 UTC, Bastien Nocera 		none Details | Review
user-accounts: Don't include link in translation (35.37 KB, patch)
2011-04-13 15:18 UTC, Bastien Nocera 		committed Details | Review

Description Luca Ferretti 2011-02-23 20:20:11 UTC 
Could be good provide a mallard document explaining how to choose a password, instead current link to http://wolfram.org/writing/howto/password.html

Pros:
  # no need to internet connection
  # translatable!

Cons:
  # someone should write it :(
Comment 1 Tiffany Antopolski 2011-02-24 21:39:26 UTC 
I don't know if this would help, but there is one in gnome-user-docs/gnome-help/C in http://git.gnome.org/browse/gnome-user-docs, titled user-goodpassword.page.
Comment 2 Bastien Nocera 2011-02-26 00:36:31 UTC 
*** Bug 643340 has been marked as a duplicate of this bug. ***
Comment 3 Matthias Clasen 2011-04-13 01:22:06 UTC 
Created attachment 185842 [details] [review]
patch
Comment 4 André Klapper 2011-04-13 12:50:14 UTC 
Did this receive a string freeze break approval before you committed that string addition? Maybe I missed some mail...
Comment 5 Bastien Nocera 2011-04-13 13:29:12 UTC 
(In reply to comment #4)
> Did this receive a string freeze break approval before you committed that
> string addition? Maybe I missed some mail...

It's not really a string addition, we're just fixing a link. If you translate it, then good, otherwise, it still links to the same external site, and no harm is done.
Comment 6 Matthias Clasen 2011-04-13 13:52:09 UTC 
What we really should do though, is to take the markup out of the translated string, and construct it in code, instead of having it in the ui file. 

Repurposing this bug for that.
Comment 7 Bastien Nocera 2011-04-13 14:20:32 UTC 
Pushed the revert, as it *actually* changes the existing string.
Comment 8 Bastien Nocera 2011-04-13 14:37:23 UTC 
Created attachment 185877 [details] [review]
user-accounts: Don't include link in translation

And use a link to local documentation, rather than an
external website in English.
Comment 9 Bastien Nocera 2011-04-13 15:18:39 UTC 
Created attachment 185882 [details] [review]
user-accounts: Don't include link in translation

And use a link to local documentation, rather than an
external website in English.

Removed mentions of "in English" for the languages that mentioned it.
Comment 10 Matthias Clasen 2011-04-13 15:25:00 UTC 
Review of attachment 185882 [details] [review]:

::: panels/user-accounts/um-password-dialog.c
@@ +659,3 @@
+                                 old_label);
+        gtk_label_set_markup (GTK_LABEL (widget), label);
+        g_free (label);

Hmm, I don't really like that.
It would be more straightforward to just use _() here and have just an untranslated placeholder in the .ui.
Comment 11 Bastien Nocera 2011-04-13 15:30:48 UTC 
Fair enough, I can fix before committing.
Comment 12 Bastien Nocera 2011-04-15 01:41:21 UTC 
Had to rebase the translations slightly.

Attachment 185882 [details] pushed as f8c3b0c - user-accounts: Don't include link in translation