After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642721 - Two minor fixes for RTL locales
Two minor fixes for RTL locales
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-19 00:03 UTC by Florian Müllner
Modified: 2011-02-19 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dash: Adjust CSS in RTL locales (1.61 KB, patch)
2011-02-19 00:04 UTC, Florian Müllner 		committed Details | Review
date-menu: Adjust boxpointer position for RTL locales (1.23 KB, patch)
2011-02-19 00:04 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-02-19 00:03:56 UTC 
See patches.
Comment 1 Florian Müllner 2011-02-19 00:04:01 UTC 
Created attachment 181292 [details] [review]
dash: Adjust CSS in RTL locales

As the dash uses different widths and radii for left and right
borders, we need to use different CSS when it is positioned at
the right of the screen.
Comment 2 Florian Müllner 2011-02-19 00:04:06 UTC 
Created attachment 181293 [details] [review]
date-menu: Adjust boxpointer position for RTL locales

We try to position the boxpointer centered above the calendar,
which swaps position with the events list when using a RTL locale,
so make the menu alignment dependent on the text direction.
Comment 3 Owen Taylor 2011-02-19 03:44:55 UTC 
Review of attachment 181292 [details] [review]:

Looks good
Comment 4 Owen Taylor 2011-02-19 03:50:18 UTC 
Review of attachment 181293 [details] [review]:

Looks good
Comment 5 Florian Müllner 2011-02-19 10:20:13 UTC 
Attachment 181292 [details] pushed as 5261304 - dash: Adjust CSS in RTL locales
Attachment 181293 [details] pushed as edc0cd3 - date-menu: Adjust boxpointer position for RTL locales