After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642500 - Folks needs API for specifying a contact's birthday
Folks needs API for specifying a contact's birthday
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other Linux
: Normal normal
: folks-0.4.0
Assigned To: folks-maint
folks-maint
Depends on: 642513
Blocks:
 
 
Reported: 2011-02-16 19:43 UTC by Raul Gutierrez Segales
Modified: 2011-03-03 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add BirthdayOwner interface (5.00 KB, patch)
2011-03-02 23:43 UTC, Raul Gutierrez Segales
none Details | Review
Complements previous patch. (736 bytes, patch)
2011-03-03 17:21 UTC, Raul Gutierrez Segales
none Details | Review
Complements previous patch. (740 bytes, patch)
2011-03-03 17:24 UTC, Raul Gutierrez Segales
none Details | Review

Description Raul Gutierrez Segales 2011-02-16 19:43:09 UTC
We should probably start with a trivial interface like

namespace Folks
{
interface BirthdayOwner :
{
    public DateTime birthday { get; set; }
    public string calendarEventId { get; set; }
}
}

and have Individual and each of the backends' Persona implementations implement
it.
Comment 1 Raul Gutierrez Segales 2011-03-02 23:43:58 UTC
Created attachment 182315 [details] [review]
Add BirthdayOwner interface

First implementation.
Comment 2 Travis Reitter 2011-03-03 00:17:06 UTC
Thanks. Merged:

commit f30fc9be93996d99b8700f8d8cad85a6ff901e32
Author: Raul Gutierrez Segales <raul.gutierrez.segales@collabora.co.uk>
Date:   Wed Mar 2 18:44:37 2011 +0000

    Add BirthdayOwner interface
    
    Fixes: bgo#642500 - Folks needs API for specifying a contact's birthday

 NEWS                      |    1 +
 folks/Makefile.am         |    1 +
 folks/birthday-owner.vala |   45 +++++++++++++++++++++++++++++++++++++++++++
 folks/individual.vala     |   47 +++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 94 insertions(+), 0 deletions(-)
Comment 3 Raul Gutierrez Segales 2011-03-03 17:21:32 UTC
Created attachment 182371 [details] [review]
Complements previous patch. 

I forgot to add the corresponding _update_birthday () call inside _update_fields (). Sorry about that.
Comment 4 Raul Gutierrez Segales 2011-03-03 17:24:48 UTC
Created attachment 182372 [details] [review]
Complements previous patch.

Corrected typo in the comment.
Comment 5 Travis Reitter 2011-03-03 17:49:35 UTC
(In reply to comment #4)
> Created an attachment (id=182372) [details] [review]
> Complements previous patch.
> 
> Corrected typo in the comment.

Applied. Thanks.

commit 203e1151df1fdea310c738c1501a84169b0330b8
Author: Raul Gutierrez Segales <raul.gutierrez.segales@collabora.co.uk>
Date:   Thu Mar 3 17:20:16 2011 +0000

    Ensure we update an Individual's birthday along with the other fields.

 folks/individual.vala |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)