After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642175 - Opacity for magnifier crosshairs is now a float
Opacity for magnifier crosshairs is now a float
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: magnifier
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-12 15:25 UTC by Bastien Nocera
Modified: 2013-12-04 18:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Opacity for magnifier crosshairs is now a float (2.28 KB, patch)
2011-02-12 15:25 UTC, Bastien Nocera 		none Details | Review
Opacity for magnifier crosshairs is now a float (2.28 KB, patch)
2011-02-12 15:30 UTC, Bastien Nocera 		accepted-commit_now Details | Review
magnifier: crosshairs opacity is now a double (2.40 KB, patch)
2011-02-13 02:23 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2011-02-12 15:25:30 UTC 
.
Comment 1 Bastien Nocera 2011-02-12 15:25:33 UTC 
Created attachment 180725 [details] [review]
Opacity for magnifier crosshairs is now a float
Comment 2 Bastien Nocera 2011-02-12 15:30:41 UTC 
Created attachment 180726 [details] [review]
Opacity for magnifier crosshairs is now a float
Comment 3 Bastien Nocera 2011-02-12 15:32:18 UTC 
Comment on attachment 180725 [details] [review]
Opacity for magnifier crosshairs is now a float

The new patch is as tested as this one (eg. not)
Comment 4 Owen Taylor 2011-02-12 18:36:27 UTC 
Review of attachment 180726 [details] [review]:

seems right, better commit message would be something like:

 magnifier: crosshairs opacity is now a float

 The type and range of the opacity has been changed in gsettings-desktop-schemas.

(Change in gsettings-desktop-schemas has no justification or bug reference ... looks sort of random.)
Comment 5 Bastien Nocera 2011-02-13 02:23:29 UTC 
Created attachment 180756 [details] [review]
magnifier: crosshairs opacity is now a double

The type of the opacity has been changed in
gsettings-desktop-schemas, and a range was added for it.

See also bug 642032
Comment 6 Bastien Nocera 2011-02-13 02:24:38 UTC 
Added the justification for the changes in the commit message.

Attachment 180756 [details] pushed as 4c2d9ca - magnifier: crosshairs opacity is now a double