After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642135 - bad UI strings (also i18n)
bad UI strings (also i18n)
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-11 21:57 UTC by Wouter Bolsterlee (uws)
Modified: 2012-02-08 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
volume: Clarify translatable string (1.15 KB, patch)
2011-09-07 12:36 UTC, Florian Müllner
accepted-commit_after_freeze Details | Review
volume: Clarify translatable string (990 bytes, patch)
2011-09-08 12:39 UTC, Florian Müllner
committed Details | Review

Description Wouter Bolsterlee (uws) 2011-02-11 21:57:49 UTC
This is not a proper sentence (actually two sentences, incorrect comma usage):

#: ../js/ui/status/bluetooth.js:243
#, c-format
msgid "The requested device cannot be browsed, error is '%s'"


This string needs a context marker to make clear this is about audio:

#: ../js/ui/status/volume.js:42
msgid "Volume"
Comment 1 Florian Müllner 2011-09-07 12:36:53 UTC
Created attachment 195867 [details] [review]
volume: Clarify translatable string

Fix for the second issue - does adding context constitute a string freeze break?
Comment 2 Dan Winship 2011-09-07 14:49:07 UTC
Comment on attachment 195867 [details] [review]
volume: Clarify translatable string

> Fix for the second issue - does adding context constitute a string freeze
> break?

I think so. Try "make update-po" in po/ and see. IIRC, this will mark the existing translation "fuzzy", which means it won't be output into the .gmo file until someone verifies that it's correct and marks it unfuzzy. You could just fix up the .po files by hand though (where "by hand" probably means "by perl"). (It's possible that some of the existing translations are for the wrong sense of "volume", but if so, you're not making things worse, and someone will eventually report the mistranslation.)
Comment 3 F Wolff 2011-09-08 09:10:10 UTC
Context markers are used to disambiguate identical strings, not to explain what something means. To just explain what a string is about, simply use comments (no string freeze break needed :-)
https://live.gnome.org/TranslationProject/DevGuidelines/Use comments
Comment 4 Florian Müllner 2011-09-08 12:39:05 UTC
Created attachment 195980 [details] [review]
volume: Clarify translatable string

(In reply to comment #3)
> To just explain what a string is about, simply use comments

Sure, can do ...
Comment 5 Owen Taylor 2012-01-24 21:06:10 UTC
Review of attachment 195980 [details] [review]:

Looks good
Comment 6 Florian Müllner 2012-02-08 16:58:46 UTC
Attachment 195980 [details] pushed as aa2a63b - volume: Clarify translatable string