GNOME Bugzilla – Bug 641880
Add a fake panel to workspace thumbnails
Last modified: 2011-02-18 16:38:02 UTC
Workspace thumbnails currently have a blank space where the panel would be which can look odd if you look closely. Adding a fake panel there would help, though sizing is a bit tricky since panel sizing depends on font sizes and is determined dynamically. Probably we should just follow the strut we set to size the fake panel? (https://bugzilla.gnome.org/show_bug.cgi?id=640996#c31)
Created attachment 180500 [details] [review] Add a black "panel" to workspace thumbnails
Patch uses name: 'panel' to pick up the style for the panel - this works, since names don't have to be unique in clutter, but I don't like it - we might eventually try to optimize things like #panel making the assumption that they are unique. But I didn't fix panel to be a style class because trying it out, it doesn't look right to me. The panel is a "frame" around the workspace contents not part of the workspace contents. We should rather exclude that part of the screen from the thumbnails, I think. For comparison, note that the workspace scroll mockup at the end of http://jimmac.musichall.cz/log/?p=1126 doesn't have panels for each workspace.
Created attachment 180527 [details] [review] workspaceThumbnails: Remove empty panel space Remove the empty panel space at the top by using a clip. --- This is closer to the mockups, but is ugly (codewise).
Review of attachment 180527 [details] [review]: Thanks! but busy rewriting all the sizing/positioning code, so this isn't going to close to apply. I'll try and come up with something once I have that done
Created attachment 180793 [details] [review] Omit the panel area from the previewed workspaces Allow defining a "porthole" that is the visible area of a workspace thumbnail, and use this to clip the portion under the panel off the workspace thumbnails. (This is wrong for fullscreen windows, but not very wrong, and hopefullly the few missing pixels will be unnoticeable.)
Review of attachment 180793 [details] [review]: Looks good - I agree that some missing pixels on fullscreen windows shouldn't matter too much.
Attachment 180793 [details] pushed as 1473a66 - Omit the panel area from the previewed workspaces