GNOME Bugzilla – Bug 641858
mpegaudioparse: Post CBR bitrate as nominal bitrate
Last modified: 2011-02-09 17:35:51 UTC
For discoverer, we don't wait for 10 frames to be parsed before collecting available metadata. Attaching a patch to post available bitrate (as nominal) for the we-hope-this-is-a-CBR-stream case.
Created attachment 180404 [details] [review] mpegaudioparse: Post CBR bitrate as nominal bitrate Even if VBR headers are missing, we can't guarantee that a stream is in fact a CBR stream, so it's safer to let baseparse calculate the average bitrate rather than assume a CBR stream. However, in order to make /some/ metadata available before the requisite number of frames have been parsed, this posts the bitrate from the non-VBR headers as the nominal bitrate.
good idea.
commit cfc3f5e43bbcc5a9c6437ad83f12e834e7307908 Author: Arun Raghavan <arun.raghavan@collabora.co.uk> Date: Tue Feb 8 23:50:13 2011 +0530 mpegaudioparse: Post CBR bitrate as nominal bitrate Even if VBR headers are missing, we can't guarantee that a stream is in fact a CBR stream, so it's safer to let baseparse calculate the average bitrate rather than assume a CBR stream. However, in order to make /some/ metadata available before the requisite number of frames have been parsed, this posts the bitrate from the non-VBR headers as the nominal bitrate. https://bugzilla.gnome.org/show_bug.cgi?id=641858