After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641853 - Trayicons not clickable while in Activities overview
Trayicons not clickable while in Activities overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Owen Taylor
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-08 17:58 UTC by Steven Garrity
Modified: 2011-03-21 18:58 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
notificationDaemon: handle trayicon clicks in the overview (2.09 KB, patch)
2011-03-16 17:48 UTC, Dan Winship
committed Details | Review

Description Steven Garrity 2011-02-08 17:58:57 UTC
Entering the Activities mode also brings up the Message Tray, but in this mode, the message tray items do not seem to be click-able. If they look the same as they do when the message tray is activated on its own (bottom-right hot-corner), they should probably behave the same.
Comment 1 Dan Winship 2011-02-08 19:00:47 UTC
You mean message tray items that are trayicons (ie, that would have been in the notification tray in GNOME 2.x), right?

There's a very old bug somewhere about making this actually work, but maybe for 3.0 we should just put a translucent gray actor over each of them.
Comment 2 Steven Garrity 2011-02-08 19:18:05 UTC
(In reply to comment #1)
> You mean message tray items that are trayicons (ie, that would have been in the
> notification tray in GNOME 2.x), right?

Yeah, the examples on my system are Pidgin and Dropbox.
Comment 3 Frederic Peters 2011-03-11 08:04:20 UTC
This bug was pointed by the marketing team as important in our latest blocker bugs meeting, I am marking it as blocker, could a mitigation like proposed in comment #2 be implemented?
Comment 4 Colin Walters 2011-03-11 15:48:42 UTC
(In reply to comment #1)
> You mean message tray items that are trayicons (ie, that would have been in the
> notification tray in GNOME 2.x), right?
> 
> There's a very old bug somewhere about making this actually work, but maybe for
> 3.0 we should just put a translucent gray actor over each of them.

What about simply bouncing out of the overview for them?
Comment 5 Dan Winship 2011-03-11 16:22:47 UTC
Could be jarring. We can try it though. (It would require bug 630842 first though.)
Comment 6 Dan Winship 2011-03-16 17:48:04 UTC
Created attachment 183558 [details] [review]
notificationDaemon: handle trayicon clicks in the overview

If the user clicks a trayicon in the overview, drop out of the
overview before passing the click on to the icon. (We have to actually
wait for the overview animation to complete, in case the icon wants to
get a pointer grab, which it would not be able to do with the overview
active.)

====

requires 630842 (and the gnome-shell-plugin.c change probably belongs
in that patch).
Comment 7 Owen Taylor 2011-03-17 21:14:36 UTC
I think the basic question here is whether this is too jarring. It seems like it might be to me before trying it out. If it's too jarring, we can probably use the dimming code for attached dialogs to "insensitize" system tray icons in the overview.
Comment 8 Owen Taylor 2011-03-18 21:12:00 UTC
Review of attachment 183558 [details] [review]:

Feels better than I thought it would - vaguely weird, but not really too jarring. Only comment is about patch division.

::: src/gnome-shell-plugin.c
@@ +340,3 @@
       if (xev->xcrossing.mode == NotifyGrab &&
+          (xev->xcrossing.detail == NotifyNonlinear ||
+           xev->xcrossing.detail == NotifyNonlinearVirtual))

Really should be in the other patch, right? otherwise you have a race if the user moves the mouse into the tray icon before the tray icon grabs.
Comment 9 Dan Winship 2011-03-21 18:58:43 UTC
Attachment 183558 [details] pushed as 22bfd4f - notificationDaemon: handle trayicon clicks in the overview