GNOME Bugzilla – Bug 641605
Add libxklavier to moduleset
Last modified: 2011-02-10 15:43:22 UTC
Due to recent changes in gnome-control-center[1], here is a patch to include libxklavier from cvs in build. [1] http://mail.gnome.org/archives/desktop-devel-list/2011-February/msg00004.html
Created attachment 180172 [details] [review] Proposed patch same solution used in jhbuild "full"
Created attachment 180174 [details] [review] Clean up Fix dependencies and make startup script install iso-codes instean libxklavier
Please also add cvs to gnome-shell-build-setup.sh, as it's not installed by default (at least in Ubuntu, but I think in other distribs too). (That's how I realized today CVS is really a legacy tool today... ;-)
Also s/startup script/setup script/ in the commit message - the startup script is called "gnome-shell" and should not install anything ;-)
Created attachment 180188 [details] [review] Updated patch * changed commit message as per Florian suggestion * added cvs to packages * added cvs and iso-codes-devel to mandriva and *suse (not so sure about mandriva...)
-# automake, bison, flex, gettext, git, gnome-common, gtk-doc, intltool, -# libtool, pkgconfig +# automake, bison, flex, gettext, gnome-common, gtk-doc, intltool, +# libtool, pkgconfig, cvs I know that's just a comment, but I would have thought Git was actually needed to build Gnome-Shell :)
Review of attachment 180188 [details] [review]: This looks fine at a high level to me.
(In reply to comment #6) > -# automake, bison, flex, gettext, git, gnome-common, gtk-doc, intltool, > -# libtool, pkgconfig > +# automake, bison, flex, gettext, gnome-common, gtk-doc, intltool, > +# libtool, pkgconfig, cvs > > I know that's just a comment, but I would have thought Git was actually needed > to build Gnome-Shell :) Mathieu, git is yet listed in required software for the script itself :)
Committed, thanks everyone.
*** Bug 641550 has been marked as a duplicate of this bug. ***