GNOME Bugzilla – Bug 641570
Messages are sometimes guillotined.
Last modified: 2011-06-03 17:51:56 UTC
Created attachment 180139 [details] test program Messages are guillotined when updated from a longer summary to a shorter one when in the expanding animation. Simple test program attached, try to hover over the notification when it prints "Hover", it's a bit tricky.
Created attachment 180141 [details] screenshot
Created attachment 188431 [details] [review] messageTray: Don't animate notifications if they've shrunk. The effect of the large gap breaks the illusion of the message attached to the bottom of the screen.
Comment on attachment 188431 [details] [review] messageTray: Don't animate notifications if they've shrunk. >- let expandedY = this.actor.height - this._notificationBin.height; >+ let expandedY = this.actor.height - this._notificationBin.height; you lost 1 space of indent across the entire patch >+ // Don't animate the notification to its new position if it has shrunk: >+ // there will be a very visible "gap" that breaks the illusion. would it work to temporarily increase its height to fill in the gap, animate it down normally, and then set the height back? (The catch would be to make sure that the "reset the height" step happens even if there's another size change or whatever during the animation.)
Created attachment 188633 [details] [review] messageTray: Don't animate notifications if they've shrunk. The effect of the large gap breaks the illusion of the message attached to the bottom of the screen. For some reason, this doesn't work... as evidenced by the "." at the end of the commit message :). If we can't figure out why, it's probably better to just go with the simpler solution.
yeah, we can go with the simpler one for now; if it annoys the designers they can file a bug :) the indentation change *is* wrong though. _onNotificationExpanded currently is indented 8 spaces, and your patch drops it to 7.
Created attachment 189055 [details] [review] messageTray: Don't animate notifications if they've shrunk. The effect of the large gap breaks the illusion of the message attached to the bottom of the screen. Is this good to commit?
Attachment 188633 [details] pushed as 0ae1556 - messageTray: Don't animate notifications if they've shrunk. Attachment 189055 [details] pushed as 0ae1556 - messageTray: Don't animate notifications if they've shrunk.