GNOME Bugzilla – Bug 641533
Workspace: don't show window overlays when leaving the overview
Last modified: 2011-02-10 21:46:03 UTC
If the user triggers the leaving of the overview while the animation to enter it is still going we call hide() on the window overlays' actors but _showWindowOverlay() was already scheduled to run on completion of the animation to enter the overview. This causes the window overlays' actors to be shown while the animation to get out of the overview is going which looks bad.
Created attachment 180102 [details] [review] Workspace: don't show window overlays when leaving the overview
Review of attachment 180102 [details] [review]: This is what the 'coverPane' is about in overview.js - it seems to work correctly when entering the overview but not when leaving, so that needs to be debugged. (I think Florian and I discuss it somewhere in bug 634948 but can't find it in a few seconds of looking.)
*** Bug 641683 has been marked as a duplicate of this bug. ***
(In reply to comment #2) > Review of attachment 180102 [details] [review]: > > This is what the 'coverPane' is about in overview.js - it seems to work > correctly when entering the overview but not when leaving, so that needs to be > debugged. (I think Florian and I discuss it somewhere in bug 634948 but can't > find it in a few seconds of looking.) You are probably referring to bug 635237 here.
> This is what the 'coverPane' is about It is not related with events. It caused by intersection of two animations. handler onComplete workspace.js:1010 (positionWindows called by zoomToOverview) executed after zoomFromOverview. patch https://bugzilla.gnome.org/attachment.cgi?id=180257 solve this problem
Created attachment 180536 [details] [review] workspace: doesn't show WindowOverlay during zoomFromOverview merge with HEAD
Review of attachment 180536 [details] [review]: Looks good and works fine here, should fix the subject though i.e s/doesn't/don't/ .