After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641399 - vp8dec: add VP8_DEBUG_TXT_* postprocessing flags
vp8dec: add VP8_DEBUG_TXT_* postprocessing flags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-03 19:26 UTC by Oleksij Rempel
Modified: 2018-01-25 19:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch vp8dec.diff v1 (796 bytes, patch)
2011-02-03 19:26 UTC, Oleksij Rempel 		none Details | Review
vp8dec v2 (978 bytes, patch)
2011-02-09 12:48 UTC, Oleksij Rempel 		committed Details | Review

Description Oleksij Rempel 2011-02-03 19:26:24 UTC 
Created attachment 180016 [details] [review]
patch vp8dec.diff v1

Add VP8_DEBUG_TXT_* flags for postprocessing. It needed to do some codec debuging and bug reporting.

see libvpx/vpx/vp8.h:
....
    VP8_DEBUG_TXT_FRAME_INFO    = 1<<3, /**< print frame information */
    VP8_DEBUG_TXT_MBLK_MODES    = 1<<4, /**< print macro block modes over each macro block */
    VP8_DEBUG_TXT_DC_DIFF       = 1<<5, /**< print dc diff for each macro block */
    VP8_DEBUG_TXT_RATE_INFO     = 1<<6, /**< print video rate info (encoder only) */

Patch is attached.
Comment 1 Oleksij Rempel 2011-02-09 12:48:28 UTC 
Created attachment 180460 [details] [review]
vp8dec v2

Updated patch: make modenames same like on theoradec.
Comment 2 Tim-Philipp Müller 2011-02-10 11:32:29 UTC 
Comment on attachment 180460 [details] [review]
vp8dec v2

Looks like these have been added recently, so maybe you could make them conditional with an #ifdef so things continue to compile with older versions of libvpx?

Will this functionality always be available at runtime, or does one need to compile libvpx with special configure switches that aren't enabled by default to get support for these flags?
Comment 3 Oleksij Rempel 2011-02-12 15:21:08 UTC 
You have right, it was add at November just after v0.9.5 . There is currently no version number to check. Looks like i should wait with it.
Comment 4 Sebastian Dröge (slomo) 2011-05-17 08:03:22 UTC 
You could add a configure check that tries to compile something with these flags to check the version.
Comment 5 Tim-Philipp Müller 2018-01-25 19:44:21 UTC 
6.5 years later, it's probably safe to push now:

commit 1bb4b83e9a5d9b9d5f443abb7bf79a19db47e244 (HEAD -> master)
Author: Oleksij Rempel <linux@rempel-privat.de>
Date:   Wed Feb 9 12:48:00 2011 +0000

    vpx: add VP8_DEBUG_TXT_* flags for postprocessing
    
    https://bugzilla.gnome.org/show_bug.cgi?id=641399