After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641384 - Make plugin loading failure fatal
Make plugin loading failure fatal
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-03 18:02 UTC by Colin Walters
Modified: 2011-02-03 19:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make plugin loading failure fatal (1.36 KB, patch)
2011-02-03 18:02 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2011-02-03 18:02:17 UTC 
If a plugin was explicitly specified, falling back to the default
silently is bad; a manager component like gnome-session can
do a better job of handling this scenario.
Comment 1 Colin Walters 2011-02-03 18:02:19 UTC 
Created attachment 180008 [details] [review]
Make plugin loading failure fatal
Comment 2 Owen Taylor 2011-02-03 19:10:39 UTC 
Review of attachment 180008 [details] [review]:

::: src/compositor/meta-plugin-manager.c
@@ +288,3 @@
+               */
+              g_error ("Unable to load plugin module [%s]: %s",
+                          path, g_module_error());

This doesn't seem like a g_error() to me - passing bad input on the command line shouldn't produce a g_error() (g_error() == bug that will be reported upstream if everything works correctly...it's a form of abort().) Should g_printerr() and exit, I think.
Comment 3 Colin Walters 2011-02-03 19:31:15 UTC 
Attachment 180008 [details] pushed as 1133a4f - Make plugin loading failure fatal