GNOME Bugzilla – Bug 641366
Calendar: no way to return to "today"
Last modified: 2014-03-05 15:42:02 UTC
Once you start navigating between months, you can't return to the current day. However, the current day is always displayed above the calendar grid. I'd suggest making the current date clickable; when clicked, the calendar grid jumps back to that day.
Yeah, that could work. In the meantime you can close and reopen it.
Created attachment 205354 [details] [review] patch I've personally run into this problem, too. Anyway, I've attempted to fix it.
Review of attachment 205354 [details] [review]: The code looks fine, but I'm a bit worried about the style - with that patch, the date is pretty much indistinguishable from a regular menu item (i.e. only the text alignment differs), but the behavior is rather different: activating the item does not close the menu as every other item does. Obviously it doesn't make sense to close the menu on activation here, so I think we should use a different style to stress that it is a button (like the month forward/backward buttons) rather than a menu item.
Created attachment 205624 [details] Screenshot with patch applied
Created attachment 270774 [details] [review] Calendar: make current date label clickable Once you start navigating between months, you can't return to the current day. However, the current day is always displayed above the calendar grid. Fix this by making the current date clickable; when clicked, the calendar grid jumps back to that day.
Created attachment 270775 [details] Srceenshot with the updated patch applied I updated the patch so that it applies again and set the style to fit the one of the forward/backward buttons.
Created attachment 270781 [details] [review] Calendar: make current date label clickable Once you start navigating between months, you can't return to the current day. However, the current day is always displayed above the calendar grid. Fix this by making the current date clickable; when clicked, the calendar grid jumps back to that day.
I noticed the focus handling is broken since the last changes to calendar.js in master as well: clicking on a day with the pointer will no longer make the day button grab the keyboard focus, I will file a separate bug for this later, this bug/patch here is just about the function and style of the new 'toady button'.
The screenshot looks great to me. I'd like to tweak the colour of the text when it is hovered, but we can do that after the patch has landed.
Review of attachment 270781 [details] [review]: ::: js/ui/dateMenu.js @@ +68,3 @@ + }); + this._date.connect('clicked', + Lang.bind(this, function() { Alignment is off by one, otherwise looks good
Created attachment 270981 [details] [review] Calendar: make current date label clickable Once you start navigating between months, you can't return to the current day. However, the current day is always displayed above the calendar grid. Fix this by making the current date clickable; when clicked, the calendar grid jumps back to that day.
Attachment 270981 [details] pushed as c07421c - Calendar: make current date label clickable