GNOME Bugzilla – Bug 641191
dvbsrc: add a property to configure the dvb-api buffer size
Last modified: 2014-06-22 13:15:12 UTC
Created attachment 179837 [details] [review] Patch + gst-indent adjustments The DVB-api is able to specify the size of the kernel-buffer for the dvr device. This can be useful for tuning. See http://www.linuxtv.org/docs/dvbapi/DVB_Demux_Device.html#SECTION00429000000000000000
Could you elaborate a bit on how/why this is useful exactly? You're drastically reducing the DMX_BUFFER_SIZE from 1MB to 8kB here if I read this correct - won't that be problematic if read()s aren't done fast enough, e.g. because downstream blocks for a short while, as often happens? (I see that 8kB is also the default buffer size, just wondering...) May I suggest that the property be a normal signed int, defaulting to -1, in which case dvbsrc just uses whatever defaults it deems best? Why not just call it "buffer-size"? Some more nitpicks: - instead of logging errno, please log g_strerror(errno). - in property description, mention that the size is in bytes - please don't indent header files, only .c files should be indented.
This patch contains a wrong PRE-DEFINED buffer size. I think being able to specify a dvb parameter should be part of our interface and it allows to fine tune your hardware. You can see all my work on this element at: https://github.com/Mistobaan/gst-plugins-bad/commits/dvbsrc_poll_tuning
dvb-buffer-size is better than buffer-size to avoid confusion ( dvb-buffer-size is the one inside the kernel
I agree being able to configure the kernel-buffer-size is a good idea. What needs to be fixed is the default value though. Can you rebase this on current 0.10 ?
Setting to NEW as this seems to be an issue that needs to be fixed as per comment #4. Fabrizio, can you rebase your patch, please? Thanks in advance!
Comment on attachment 179837 [details] [review] Patch + gst-indent adjustments default buffer size adjusted.
This enhancement was committed as fe5cf525e1de8320d1db67914 with the default buffer size to (10*188*1024). Closing.