After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641164 - Fix various gcc warnings
Fix various gcc warnings
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other All
: Normal normal
: ---
Assigned To: Li Yuan
Depends on:
Blocks:
 
 
Reported: 2011-02-01 16:14 UTC by Frederic Crozat
Modified: 2011-02-02 10:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add missing standard headers (915 bytes, patch)
2011-02-01 16:14 UTC, Frederic Crozat 		committed Details | Review
Add missing return values (2.29 KB, patch)
2011-02-01 16:14 UTC, Frederic Crozat 		committed Details | Review
Ensure variable is initialized (785 bytes, patch)
2011-02-01 16:14 UTC, Frederic Crozat 		committed Details | Review
registryd fix. (836 bytes, patch)
2011-02-02 00:29 UTC, Mike Gorse 		committed Details | Review

Description Frederic Crozat 2011-02-01 16:14:43 UTC 
This patch serie fixes warnings found when packaging at-spi2-core 1.91.x
on openSUSE 11.3
Comment 1 Frederic Crozat 2011-02-01 16:14:47 UTC 
Created attachment 179807 [details] [review]
Add missing standard headers
Comment 2 Frederic Crozat 2011-02-01 16:14:53 UTC 
Created attachment 179808 [details] [review]
Add missing return values
Comment 3 Frederic Crozat 2011-02-01 16:14:59 UTC 
Created attachment 179809 [details] [review]
Ensure variable is initialized
Comment 4 Mike Gorse 2011-02-01 17:07:22 UTC 
Comment on attachment 179809 [details] [review]
Ensure variable is initialized

All of these look fine; thanks for the patches. (I'm assuming you have commit access on git.gnome.org)
Comment 5 Frederic Crozat 2011-02-01 17:11:29 UTC 
Attachment 179807 [details] pushed as 3cd7ebf - Add missing standard headers
Attachment 179808 [details] pushed as cfac92c - Add missing return values
Attachment 179809 [details] pushed as 68fd6e9 - Ensure variable is initialized
Comment 6 Mike Gorse 2011-02-02 00:29:14 UTC 
Created attachment 179849 [details] [review]
registryd fix.

Fyi, I didn't review that patch carefully enough--signal_filter was returning the wrong value for non-signals, so at-spi2-registryd would not process any method calls.  If you apply these patches in a package, then please apply this one on top of the others.
Comment 7 Frederic Crozat 2011-02-02 10:13:00 UTC 
oops, sorry about that, I wasn't 100% sure on the return value to use.

I've grabbed your patch for openSUSE until a new release is done with it.