After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640723 - Port 2.34 to Folks 0.3?
Port 2.34 to Folks 0.3?
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Meta Contacts
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on: 627397
Blocks:
 
 
Reported: 2011-01-27 14:21 UTC by Guillaume Desmottes
Modified: 2011-02-02 10:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Backports for Folks 0.3.4 to Empathy 2.34 (46.85 KB, patch)
2011-02-01 23:09 UTC, Travis Reitter
none Details | Review

Description Guillaume Desmottes 2011-01-27 14:21:26 UTC
We are backporting some nice Empathy 3.0 features to a 2.34 branch still using GTK+ 2. Atm I can't easily build it because I have Folks 0.3 installed and 2.34 still use Folks 0.2 (and we can't have both installed :( ).

Would it make sense to backport the Folks API change to this branch and make use of Folks 0.3 in it?
Comment 1 Philip Withnall 2011-01-27 16:39:37 UTC
I guess it depends overall on what the GNOME dependency on libfolks is for 2.34. The API changes so far aren't too big, although the fix for bug #637151 might be fairly big. I guess it depends on how much you want anti-linking and a fix for bug #637151 in Empathy 2.34, since those are the major changes from libfolks 0.2 → 0.3 which would affect Empathy.

Travis, what have I forgotten?
Comment 2 Frederic Peters 2011-01-27 16:43:52 UTC
There won't be an official GNOME 2.34 release, so you're free to depend on the version of libfolks you want.
Comment 3 Guillaume Desmottes 2011-01-28 13:34:30 UTC
Natty already uses Folks 0.3.3 so I think we should go for it.

Philip/Travis: could you please cherry-pick the patches we need to backport to the gnome-2.34 branch please?
Comment 4 Philip Withnall 2011-01-29 15:12:11 UTC
(In reply to comment #3)
> Philip/Travis: could you please cherry-pick the patches we need to backport to
> the gnome-2.34 branch please?

Will do once we've committed the fix for bug #627397 and made a 0.3.4 release. When are you planning on making the Empathy 2.34 release?
Comment 5 Guillaume Desmottes 2011-01-31 08:58:45 UTC
Hopefully soon, but I can wait a bit if needed.
Comment 6 Travis Reitter 2011-02-01 23:09:11 UTC
Created attachment 179847 [details] [review]
Backports for Folks 0.3.4 to Empathy 2.34

Patches for branch:

http://git.collabora.co.uk/?p=user/treitter/empathy.git;a=shortlog;h=refs/heads/gnome-2-34-backports

=================================

I couldn't test this out beyond buildability, since my main dev environment is Gnome 3.0 (and my Gnome 2.32 jhbuild environment fails to build half the deps), but I imagine it should be fine.

Please test it out and apply if it works.
Comment 7 Guillaume Desmottes 2011-02-02 10:15:28 UTC
Awesome; thanks a lot! I merged it myself as I'll try to make the first release today.


This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.