After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640607 - appsink never sends "new-buffer-list" signal
appsink never sends "new-buffer-list" signal
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-25 23:59 UTC by Youness Alaoui
Modified: 2011-01-31 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Send "new-buffer-list" signal (1.45 KB, patch)
2011-01-26 02:31 UTC, Cai Yuanqing 		none Details | Review

Description Youness Alaoui 2011-01-25 23:59:52 UTC 
Latest git version of appsink has : 
gst-plugins-base/gst-libs/gst/app/gstappsink.c line 780 :
  if (is_list) {
    if (priv->callbacks.new_buffer_list)
      priv->callbacks.new_buffer_list (appsink, priv->user_data);
  } else {
    if (priv->callbacks.new_buffer)
      priv->callbacks.new_buffer (appsink, priv->user_data);
    else if (emit)
      g_signal_emit (appsink, gst_app_sink_signals[SIGNAL_NEW_BUFFER], 0);
  }


doing a grep shows that the "new-buffer-list" signal is created in the class_init but it's never used anywhere, it seems clear that there's a line missing there.

Thanks.
Comment 1 Cai Yuanqing 2011-01-26 02:31:59 UTC 
Created attachment 179348 [details] [review]
Send "new-buffer-list" signal

I check out gstappsink.c and make this signal to be sent.

This patch may fix this bug.
Comment 2 Wim Taymans 2011-01-31 14:33:25 UTC 
commit 71dec68cbab5f72f4cd7d884903cfdb19e27fda6
Author: Cai Yuanqing <Yuanqing.Cai@tieto.com>
Date:   Wed Jan 26 10:32:32 2011 +0800

    appsink: send new-buffer-list signal
    
    Send new-buffer-list signal when emit-signals is TRUE
    
    https://bugzilla.gnome.org/show_bug.cgi?id=640607