GNOME Bugzilla – Bug 640447
Fix gcc 4.6 warnings
Last modified: 2011-01-24 18:40:10 UTC
See patches; the first is miscellaneous correct fixes, the second preserves the current behavior, but that behavior might be a bug, and the third fixes a bug.
Created attachment 179197 [details] [review] Remove set-but-unused variables, to appease gcc 4.6
Created attachment 179198 [details] [review] shell-app-usage: remove a set-but-unused variable FIXME: is this right? should there be an "if (running)" or "if (!running)"?
Created attachment 179199 [details] [review] shell-doc-system: fix %-escaping code in shell_doc_system_open() It was escaping app_exec into app_exec_quoted, but then forgot about it and went back to using app_exec.
Review of attachment 179197 [details] [review]: Assuming that none of the getters have mysterious side effects, and it compiles, it basically has to be right.
Review of attachment 179198 [details] [review]: adding an 'if (running)' seems most plausible there to me - it doesn't seem like we'd want to record an app as "seen" an extra time when it changes to the stopped state. (The app usage code isn't actually used - and the algorithms it uses don't make a ton of sense to me. The original Mugshot code for application usage had a pretty simple and thought-through way of counting app usage, but that hasn't been preserved. So, in other words, who knows. I don't think adding an 'if (running)' would hurt anything.)
Review of attachment 179199 [details] [review]: Looks good
pushed with the suggested fix to shell-app-usage Attachment 179197 [details] pushed as 13edecd - Remove set-but-unused variables, to appease gcc 4.6 Attachment 179199 [details] pushed as 6f07031 - shell-doc-system: fix %-escaping code in shell_doc_system_open()