After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640361 - Minor comment bug in workspace.js
Minor comment bug in workspace.js
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-24 00:37 UTC by Owen Taylor
Modified: 2011-02-21 18:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
workspaces: Remove obsolete comment (834 bytes, patch)
2011-02-19 23:39 UTC, drago01
committed Details | Review

Description Owen Taylor 2011-01-24 00:37:53 UTC
// Create clones for remaining windows that should be
        // visible in the Overview
        this._windows = [];
        this._windowOverlays = [];
        for (let i = 0; i < windows.length; i++) {
            if (this._isOverviewWindow(windows[i])) {
                this._addWindowClone(windows[i]);
            }
        }

I think "remaining" here above refers to the way we used to find and special case the desktop window if any - has no relevance to current code.
Comment 1 drago01 2011-02-19 23:39:52 UTC
Created attachment 181372 [details] [review]
workspaces: Remove obsolete comment

---

<rant> Fixing this two bugs would have taken you equally or even less time then filling bugs ;) </rant>
Comment 2 Owen Taylor 2011-02-21 14:59:37 UTC
Review of attachment 181372 [details] [review]:

I probably didn't have a clean tree or someone to ask for a pastebin review
Comment 3 drago01 2011-02-21 18:23:47 UTC
Attachment 181372 [details] pushed as 3fd908d - workspaces: Remove obsolete comment