After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640005 - removable media dialog should use app names
removable media dialog should use app names
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkAppChooser
2.99.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Cosimo Cecchi
Depends on:
Blocks:
 
 
Reported: 2011-01-19 22:33 UTC by William Jon McCann
Modified: 2011-01-22 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (42.69 KB, image/png)
2011-01-19 22:33 UTC, William Jon McCann 		  Details
screenshot of other app dialog (58.22 KB, image/png)
2011-01-19 22:34 UTC, William Jon McCann 		  Details
Use actual app name in app choosers (4.15 KB, patch)
2011-01-20 21:41 UTC, William Jon McCann 		none Details | Review

Description William Jon McCann 2011-01-19 22:33:50 UTC 
Created attachment 178795 [details]
screenshot

The removable media panels shows names for apps that aren't the real names.  It should use the name from the desktop file instead.

For example, in the attached screenshot we should see "Brasero" and "Rhythmbox".
Comment 1 William Jon McCann 2011-01-19 22:34:57 UTC 
Created attachment 178796 [details]
screenshot of other app dialog

Same here.
Comment 2 William Jon McCann 2011-01-19 22:50:36 UTC 
Also it probably shouldn't show the comment.  We don't show that in the shell app view for example.
Comment 3 William Jon McCann 2011-01-20 21:34:23 UTC 
g_desktop_app_info_get_display_name () does this:
  if (info->fullname == NULL)
    return g_desktop_app_info_get_name (appinfo);
  return info->fullname;

Which seems wrong to me but we can just use get_name I guess.
Comment 4 William Jon McCann 2011-01-20 21:41:25 UTC 
Created attachment 178890 [details] [review]
Use actual app name in app choosers

Instead of using a strange composite of name and generic name.
Comment 5 Bastien Nocera 2011-01-21 12:04:06 UTC 
GTK+ patch, pushing there.
Comment 6 Matthias Clasen 2011-01-22 13:59:41 UTC 
commit 120e289f56aad67b1db15801d1b7ef61c8b0c2cc
Author: William Jon McCann <jmccann@redhat.com>
Date:   Thu Jan 20 16:40:29 2011 -0500

    Use actual app name in app choosers
    
    Instead of using a strange composite of name and generic name.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=640005