After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639917 - [PATCH] Crash inserting integers into TreeStore
[PATCH] Crash inserting integers into TreeStore
Status: RESOLVED FIXED
Product: meld
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Kai Willadsen
meld-maint
: 645473 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-01-19 04:10 UTC by Robert Ancell
Modified: 2011-03-22 22:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Convert integer columns to strings (1.48 KB, patch)
2011-01-19 04:10 UTC, Robert Ancell 		none Details | Review
Patch (2.85 KB, patch)
2011-01-30 01:40 UTC, Kai Willadsen 		none Details | Review

Description Robert Ancell 2011-01-19 04:10:22 UTC 
Created attachment 178681 [details] [review]
Convert integer columns to strings

Meld crashes starting a dir diff when it tries to set the state in the TreeStore.  The state is an integer and the tree store only has string columns.  My guess is GTK/PyGTK has got more picky at some point.  The attached patch just converts these integers to strings.

Downstream bug:
https://bugs.launchpad.net/ubuntu/+source/meld/+bug/703603
Comment 1 Kai Willadsen 2011-01-30 01:25:57 UTC 
I think the commit in question is probably:
http://git.gnome.org/browse/pygtk/commit/?id=6aedd7dbb30e52a10a0379d95e0e8b26bd7be84e
Comment 2 Kai Willadsen 2011-01-30 01:40:37 UTC 
Created attachment 179622 [details] [review]
Patch

I've adapted the original patch to also fix the problem for Error rows, and fixed some issues with the original patch (carried over from the original code, not the patch's fault).

However, I can't actually reproduce the bug here. Can I get confirmation that this new patch actually fixes the bug?

(Specifically, the pygtk code looks like it will happily store None in a String column, but I'd like to be sure.)
Comment 3 Kai Willadsen 2011-02-05 22:28:27 UTC 
I'm just going to assume that the patch works. I've pushed it to HEAD. Please reopen if the problem remains.
Comment 4 Kai Willadsen 2011-03-22 22:29:20 UTC 
*** Bug 645473 has been marked as a duplicate of this bug. ***