After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639914 - url highlight is broken
url highlight is broken
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-19 01:47 UTC by Maxim Ermilov
Modified: 2011-01-19 02:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
messageTray: fix url highlight (1.17 KB, patch)
2011-01-19 01:49 UTC, Maxim Ermilov
committed Details | Review

Description Maxim Ermilov 2011-01-19 01:47:11 UTC
problem appear after 19ac1f8b666ff0cf51395b04e5deadebed2626a5

patch follow
Comment 1 Maxim Ermilov 2011-01-19 01:49:44 UTC
Created attachment 178680 [details] [review]
messageTray: fix url highlight
Comment 2 Florian Müllner 2011-01-19 02:00:49 UTC
Review of attachment 178680 [details] [review]:

I came up with the same patch after the problem was mentioned on IRC, so I guess it's OK, though it definitively needs a more verbose commit message; for reference, this is what I used:

util: Fix regex used to match for URLs
 
Commit a65a0f03d49 changed the literal RegExp to a string-based
RegExp(). As backslashes are treated specially inside strings,
translating an expression as /\s/ to '\s' results in a faulty
regex of /s/, so escape backslashes where necessary.