After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639896 - Change the SONAME if built against webkitgtk 3.0
Change the SONAME if built against webkitgtk 3.0
Status: RESOLVED FIXED
Product: seed
Classification: Bindings
Component: libseed
git master
Other Linux
: Normal normal
: ---
Assigned To: seed-maint
: 596616 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-01-18 21:34 UTC by Emilio Pozuelo Monfort
Modified: 2011-03-01 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change soname and install directory when building gtk3 version (13.15 KB, patch)
2011-02-02 16:19 UTC, Frederic Crozat
committed Details | Review

Description Emilio Pozuelo Monfort 2011-01-18 21:34:03 UTC
Hi,

Currently, libseed has the same SONAME when built against webkit 1.0 and webkitgtk 3.0. This is wrong since an application A linked against libseed and webkit 1.0 would load both webkit 1.0 and webkitgtk 3.0 into its process if libseed was rebuilt with webkitgtk 3.0 support, since the SONAME didn't change.

This is the same situation as with GTK+ 2 and 3. For example vte has a different SONAME when built against gtk+ 2 and 3, even if its API hasn't changed.
Comment 1 Alan Knowles 2011-01-18 23:53:22 UTC
Needs a patch - guessing something like 

configure.am  - set a variable SEED_GTK_VERSION = -gtk2 or -gtk3

libseed/Makefile.am - append this to lib_LTLIBRARIES
eg.

lib_LTLIBRARIES = \
	libseed$(SEED_GTK_VERSION).la

Not sure what knock on effects there are.
Comment 2 Emilio Pozuelo Monfort 2011-01-19 00:21:39 UTC
Sounds good to me. I wouldn't embed 'gtk' on the library name though, since libseed doesn't really link to gtk+ directly, this is an unfortunate side effect of libjsc being embedded in libwebkit.

The good fix would be for libjsc to be splitted from libwebkit, so this wouldn't be necessary. But for the time being we're gonna have to change the SONAME.

https://bugs.webkit.org/show_bug.cgi?id=19428
Comment 3 Frederic Crozat 2011-02-02 16:19:38 UTC
Created attachment 179899 [details] [review]
Change soname and install directory when building gtk3 version

This patch ensures include directory, extensions, modules and shared
libraries do not collide with gtk2 version
Comment 4 Emilio Pozuelo Monfort 2011-02-15 21:10:56 UTC
Alan, does Frederic's patch look good to you?
Comment 5 Alan Knowles 2011-02-15 23:56:34 UTC
yes, this looks good,

it might need
SEED_GTK_VERSION=
inside the gtk-2 condition, to make sure that that variable get's set? (no idea if autotools/make etc. would bork in that case..)

Just make sure it builds with gtk2 and feel free to commit.

Regards
Alan
Comment 6 Frederic Crozat 2011-02-16 06:19:40 UTC
I checked before putting the patch here that is was still building with gtk2.

committing to head.
Comment 7 Emilio Pozuelo Monfort 2011-02-16 09:42:45 UTC
A new release with this fix would be nice :)
Comment 8 Alan Knowles 2011-02-16 09:45:48 UTC
Tim's the only one who can release it as far as I know

Hopefully Tim's on the CC list, however might be worth emailing him directly.
Comment 9 Tim Horton 2011-02-17 00:10:45 UTC
Yikes, it's been a while since we've made a release. I'm not the only one, but I'll do it this weekend, I just have to find a functioning Linux box. *keep me to that*, if it's not done by monday, start spamming me!
Comment 10 Alan Knowles 2011-02-17 05:28:04 UTC
*** Bug 596616 has been marked as a duplicate of this bug. ***
Comment 11 Emilio Pozuelo Monfort 2011-02-22 21:54:47 UTC
(In reply to comment #9)
> if it's not done by monday, start spamming me!

*spam* :)
Comment 12 Frederic Peters 2011-02-22 22:07:25 UTC
double spam :)

Tim, it would be really helpful if you could do a release; if it's not possible, please contact the release team, we'll help.
Comment 13 Tim Horton 2011-02-22 23:00:04 UTC
Done!
Comment 14 Vincent Untz 2011-03-01 15:10:44 UTC
Would be nice to also have a different pkg-config filename, so you can have both development versions installed at the same time.