GNOME Bugzilla – Bug 639896
Change the SONAME if built against webkitgtk 3.0
Last modified: 2011-03-01 15:10:44 UTC
Hi, Currently, libseed has the same SONAME when built against webkit 1.0 and webkitgtk 3.0. This is wrong since an application A linked against libseed and webkit 1.0 would load both webkit 1.0 and webkitgtk 3.0 into its process if libseed was rebuilt with webkitgtk 3.0 support, since the SONAME didn't change. This is the same situation as with GTK+ 2 and 3. For example vte has a different SONAME when built against gtk+ 2 and 3, even if its API hasn't changed.
Needs a patch - guessing something like configure.am - set a variable SEED_GTK_VERSION = -gtk2 or -gtk3 libseed/Makefile.am - append this to lib_LTLIBRARIES eg. lib_LTLIBRARIES = \ libseed$(SEED_GTK_VERSION).la Not sure what knock on effects there are.
Sounds good to me. I wouldn't embed 'gtk' on the library name though, since libseed doesn't really link to gtk+ directly, this is an unfortunate side effect of libjsc being embedded in libwebkit. The good fix would be for libjsc to be splitted from libwebkit, so this wouldn't be necessary. But for the time being we're gonna have to change the SONAME. https://bugs.webkit.org/show_bug.cgi?id=19428
Created attachment 179899 [details] [review] Change soname and install directory when building gtk3 version This patch ensures include directory, extensions, modules and shared libraries do not collide with gtk2 version
Alan, does Frederic's patch look good to you?
yes, this looks good, it might need SEED_GTK_VERSION= inside the gtk-2 condition, to make sure that that variable get's set? (no idea if autotools/make etc. would bork in that case..) Just make sure it builds with gtk2 and feel free to commit. Regards Alan
I checked before putting the patch here that is was still building with gtk2. committing to head.
A new release with this fix would be nice :)
Tim's the only one who can release it as far as I know Hopefully Tim's on the CC list, however might be worth emailing him directly.
Yikes, it's been a while since we've made a release. I'm not the only one, but I'll do it this weekend, I just have to find a functioning Linux box. *keep me to that*, if it's not done by monday, start spamming me!
*** Bug 596616 has been marked as a duplicate of this bug. ***
(In reply to comment #9) > if it's not done by monday, start spamming me! *spam* :)
double spam :) Tim, it would be really helpful if you could do a release; if it's not possible, please contact the release team, we'll help.
Done!
Would be nice to also have a different pkg-config filename, so you can have both development versions installed at the same time.